Skip to content

ath9k: ASPM fixes

John W. Linville ath9k-devel linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ath9k-devel] [PATCH -next 0/8] ath9k: ASPM fixes
Quoted 25 lines · Stanislaw Gruszka

This patch series try to fix ath9k ASPM. Some of patches are cleanup only or do merging common code (with e1000e driver).

With CONFIG_PCIEASPM it's possible to change ASPM settings on runtime via /sys/module/pcie_aspm/parameters/policy . However most drivers I looked at assume this setting is constant. I add a callback to pci driver to inform about the change, and allow driver to do needed hw related changes. Currently only ath9k implement the callback, but I think it will be useful for other drivers i.e. iwlwifi, rtlwifi that do some own ASPM handling.

Would be nice to get some testing on patches on different platforms with ath9k devices on kernel compiled with CONFIG_PCIEASPM (default) and mixing up commands:

echo powersave > /sys/module/pcie_aspm/parameters/policy echo performance > /sys/module/pcie_aspm/parameters/policy ifconfig wlan0 down
ifconfig wlan0 up
pm-suspend

Cc Jesse Barnes <[email protected]>
Cc linux-pci at vger.kernel.org
Cc Jeff Kirsher <[email protected]>
Cc e1000-devel at lists.sourceforge.net
Quoted 14 lines
---
 drivers/net/e1000e/netdev.c                |   31 ----------
 drivers/net/wireless/ath/ath9k/ar9002_hw.c |   12 ---
 drivers/net/wireless/ath/ath9k/ar9003_hw.c |   12 ---
 drivers/net/wireless/ath/ath9k/hw-ops.h    |    9 +-
 drivers/net/wireless/ath/ath9k/hw.c        |   17 +++--
 drivers/net/wireless/ath/ath9k/hw.h        |   12 +--
 drivers/net/wireless/ath/ath9k/main.c      |    8 --
 drivers/net/wireless/ath/ath9k/pci.c       |   88 ++++++++++++++++++++++-------
 drivers/pci/pcie/Makefile                  |    3 
 drivers/pci/pcie/aspm.c                    |   46 ++++++++++++++-
 include/linux/pci-aspm.h                   |    2 
 include/linux/pci.h                        |    3 
 12 files changed, 148 insertions(+), 95 deletions(-)

I'm happy to take patches 1-3 through my tree. But maybe patches 4-8 should go through a PCI tree? Or at least get some ACKS from the appropriate maintainers to take these changes through the wireless trees?

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

Read the cover letter in its thread