Skip to content

kthreads: allow_signal: don't play with ->blocked

Oleg Nesterov linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1kthreads: allow_signal: don't play with ->blockedkernel/exit.c+2 -36 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] kthreads: allow_signal: don't play with ->blocked
Quoted 8 lines · Oleg Nesterov
Quoted 8 lines

int allow_signal(int sig)
{

(quoted diff) +2 -0
+	sigset_t blocked;
+
 	if (!valid_signal(sig) || sig < 1)
 		return -EINVAL;
Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +0 -0
 	spin_lock_irq(&current->sighand->siglock);
 	/* This is only needed for daemonize()'ed kthreads */

Exactly. And nowadays the daemonize()'ed kthreads should not play with allow_signal().

And more, I think it is the time to kill daemonize(). Contrary to what /bin/grep thinks, it has only one user.

No, daemonize() has no users which actually need it.

Imho we should deprecate it, it has no users after the patches I sent.

Quoted 1 line

In short: this code in allow_signal() should die.

Yes.

To clarify: this change breaks drivers/staging/rtl8712/, but I belive it is wrong and should be fixed. I have already sent the patch.

Oleg.

Read the cover letter in its thread