Skip to content

Clean up some io.h and associated code

Arnd Bergmann linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 10 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 10 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Clean up some io.h and associated code
Quoted 3 lines · Russell King - ARM Linux

This series does some cleanup of the mach/io.h header files and associated definitions, including getting rid of quite a lot of IO_SPACE_LIMIT definitions.

Hi Russell,

This looks very nice!

I did some research during the Cambourne meeting about of these and found that the omap1 and a91 platforms also need the IO_SPACE_LIMIT defined to 0xffffffff when CONFIG_AT91_CF or CONFIG_OMAP_CF are set, so these fall into the same category as CONFIG_PCMCIA_SOC_COMMON.

How about a new Kconfig symbol for this special I/O mode that is selected by the three drivers? That would take care of all remaning PCCARD users and simplify the generic IO_SPACE_LIMIT definition to

#ifndef IO_SPACE_LIMIT
#if defined(CONFIG_IO_SPACE_VIRTUAL) /* maybe you have a better name */ #define IO_SPACE_LIMIT ((resource_size_t)0xffffffff)
#elif defined(CONFIG_PCI) || defined(CONFIG_ISA)
#define IO_SPACE_LIMIT ((resource_size_t)0xffff)
#else
#define IO_SPACE_LIMIT ((resource_size_t)0)
#endif
#endif

The platforms that currently use PCI or ISA in the same way can then also set that symbol and get rid of their private definition, or converted over to having a single 64k window.

Arnd