Skip to content

freezer: fix wait_event_freezable/__thaw_task races

Oleg Nesterov containers linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1freezer: fix wait_event_freezable/__thaw_task racesinclude/linux/freezer.h+10 -90 replies
1/1freezer: fix wait_event_freezable/__thaw_task racesinclude/linux/freezer.h+10 -99 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] freezer: fix wait_event_freezable/__thaw_task races

Hi,

Quoted 10 lines · Tejun Heo
Quoted 7 lines

I meant, unless the caller plays with allow_signal(), it has all rights to do

	if (wait_event_freezable(...))
		BUG();

This becomes correct with the code above.

Yeap, sure, w/ freezable_with_signal gone, the above should work fine. Care to create a patch?

Sure.

But. Tejun, Rafael, I have to rely on your review. I have no idea how can I test this change. Hopfully it is simple enough, though.

And. wait_event_freezable_timeout() obviously has another problem, although I hope this is fine. The caller can spend a lot of time in refrigerator, shouldn't we update "timeout" in this case? I hope we shouldn't.

Oleg.

Read the cover letter in its thread