Skip to content

ARM: imx: Add cpuidle for imx platforms

Sascha Hauer linux-arm-kernel 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 3 patches 0 repliesNew
  2. v2 posting 1/20 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] ARM: imx: Add cpuidle for imx platforms
Quoted 44 lines · Rob Lee

Hello Sascha,

Quoted 7 lines · Sascha Hauer

Hi Robert,

Quoted 4 lines · Robert Lee

This patch series adds a common imx cpuidle driver, some common mach-mx5 level cpuidle functionality, and an i.MX51 instance of using this driver.

Quoted 8 lines
Quoted 5 lines

The patch series is based on v3.1-rc2.

Changes since v1:
* To address all the problems found during review of v1, a complete re-write was needed.

Much better than the last version, thanks.

Thanks to Shawn Guo for thoroughly reviewing and providing feedback on this version and Jason Hui contributed to the reviewing as well despite both of them being very busy with there own submissions.

Quoted 11 lines
Quoted 8 lines

Robert Lee (3):
? ARM: imx: Add imx cpuidle driver
? ARM: imx: Add cpuidle for mach-mx5
? ARM: imx: Add cpuidle for i.MX51

?arch/arm/mach-mx5/Makefile ? ? ? ? ? ? ? | ? ?3 +- ?arch/arm/mach-mx5/cpu_op-mx51.c ? ? ? ? ?| ? 35 +++++++-

Your additions to this file...

Quoted 8 lines
Quoted 3 lines
?arch/arm/mach-mx5/cpu_op-mx51.h ? ? ? ? ?| ? ?1 +
?arch/arm/mach-mx5/mm.c ? ? ? ? ? ? ? ? ? | ? ?4 +
?arch/arm/mach-mx5/system.c ? ? ? ? ? ? ? | ? 35 +++++++

And this one should go to arch/arm/mach-mx5/cpuidle.c, then we have all i.MX5 specific cpuidle stuff together without ifdeffing the code. I assume that cpuidle support for i.MX53 will look identically, right?

Quoted 12 lines

After considering it further after the first patch, there can be differences between the i.MX51 and i.MX53 state data as i.MX51 supports an additional idle state that i.MX53 does not. This state was not added to this version of the patch because it's additional power savings is very small and there is fairly time consuming characterization needed to come up with accurate cpuidle state data. But to allow for the possibility that this state could be added in the future, it seemed the choice was to add this init data to the an i.MX51 specific file such as cpu_op-mx51.c/h and add ifdefs for cpuidle and cpufreq. Or, make a cpuidle.c file as you suggest and add ifdefs for the different mx5 SoCs. Just let me know which way you think is better given this information.

Just put it in cpuidle.c for now. Better to have the cpuidle stuff together in one file. We can still decide to move it to another place should the need arise.

Quoted 5 lines

For the call to imx_cpuidle_init from imx51_soc_init in mm.c, this seems like a good location to initialize for all imx51_soc. If I don't call the init from here, can you recommend another location that I should call it from?

Calling it from mm.c is fine.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Read the cover letter in its thread