Skip to content

git-p4 tests, filetypes, shell metacharacters

Pete Wyckoff git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 6 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6git-p4 tests: refactor and cleanupt/lib-git-p4.sh t/t9800-git-p4.sh t/t9801-git-p4-branch.sh+558 -3233 replies
2/6git-p4: handle utf16 filetype properlycontrib/fast-import/git-p4 t/t9802-git-p4-filetype.sh+119 -02 replies
3/6git-p4: recognize all p4 filetypescontrib/fast-import/git-p4+52 -190 replies
4/6git-p4: stop ignoring apple filetypecontrib/fast-import/git-p4+0 -50 replies
5/6git-p4: keyword flattening fixescontrib/fast-import/git-p4+6 -20 replies
6/6git-p4: handle files with shell metacharacterscontrib/fast-import/git-p4 t/t9803-git-shell-metachars.sh+187 -770 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchLuke Diamand
1/6
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] git-p4 tests, filetypes, shell metacharacters

This series of six patches has been reviewed on the mailing list and should be ready for inclusion.

1 - Clean up git-p4 tests, including Junio review comments

2..4 - Handle p4 filetypes better, including Chris's suggested
utf16 fix

5 - Fix p4 keyword parsing

6 - From Luke: avoid using the shell, so filenames with metacharacters
are not errantly expanded

Luke Diamand (1):
git-p4: handle files with shell metacharacters

Pete Wyckoff (5):
git-p4 tests: refactor and cleanup
git-p4: handle utf16 filetype properly
git-p4: recognize all p4 filetypes
git-p4: stop ignoring apple filetype
git-p4: keyword flattening fixes

 contrib/fast-import/git-p4     |  287 +++++++++++++-------
 t/lib-git-p4.sh                |   74 +++++
 t/t9800-git-p4.sh              |  574 ++++++++++++++++++----------------------
 t/t9801-git-p4-branch.sh       |  233 ++++++++++++++++
 t/t9802-git-p4-filetype.sh     |  108 ++++++++
 t/t9803-git-shell-metachars.sh |   64 +++++
 6 files changed, 918 insertions(+), 422 deletions(-)
 create mode 100644 t/lib-git-p4.sh
 create mode 100755 t/t9801-git-p4-branch.sh
 create mode 100755 t/t9802-git-p4-filetype.sh
 create mode 100755 t/t9803-git-shell-metachars.sh