RFC Rework of the debug() macro
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 39 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 39 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Detlev Zundel |
|---|---|
| Series | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro
Quoted 20 lines · Detlev Zundel
Hi Marek,
[...]
Quoted 2 lines
So because noone actually bothered to compile u-boot with DEBUG enabled, we (me ?) now have literally piles of places to fix. Hm :-(
So it seems. This is a very good reminder of the fact that with ifdef we actually hide source code from the compiler under certain circumstances. The number of these "certain circumstances" produces the number of
_differinginput_to our compiler. Given the trivial fact that a simple ifdef results in two different inputs one needs only to visualize the graph of 2^x to get an idea of how many sources we are actually using.Unrelated to your current efforts (that are greatly appreciated) We should really try not to use #ifdef at all. Using constants together with the dead code eliminatino of the compiler can usually reach the same goal but with syntax checks on every compile.
Quoted 5 lines
Sorry, but I couldn't resist lobbying for this. Perhaps it helps when it gets repeated approximately every year ;)
Cheers
Detlev
Hey Detlev,
I certainly see your point. Btw. do you feel like help reviewing the PPC portion of the patches? That'd be greatly appreciated as I'm not a PPC expert. I wanted to avoid resubmission, so I only pushed the new set to git://git.denx.de/u-boot-
marex.git / debug branch. There is over 50 patches now.
Cheers