Add clk_prepare/clk_unprepare for mxs clock api
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | clk: add helper functions clk_prepare_enable and clk_disable_unprepare | +0 | 1 reply | |
| 2/12 | arm/mxs: convert platform code to clk_prepare/clk_unprepare | +0 | 1 reply | |
| 2/12 | arm/mxs: convert platform code to clk_prepare/clk_unprepare | +0 | 0 replies | |
| 3/12 | net: fec: add clk_prepare/clk_unprepare | +0 | 0 replies | |
| 4/12 | dma: mxs-dma: convert to clk_prepare/clk_unprepare | +0 | 1 reply | |
| 5/12 | mmc: mxs-mmc: convert to clk_prepare/clk_unprepare | +0 | 0 replies | |
| 6/12 | mtd: gpmi-lib: convert to clk_prepare/clk_unprepare | +0 | 0 replies | |
| 7/12 | net: flexcan: convert to clk_prepare/clk_unprepare | +0 | 1 reply | |
| 8/12 | serial: mxs-auart: convert to clk_prepare/clk_unprepare | +0 | 3 replies | |
| 8/12 | serial: mxs-auart: convert to clk_prepare/clk_unprepare | +0 | 1 reply | |
| 8/12 | serial: mxs-auart: convert to clk_prepare/clk_unprepare | +0 | 0 replies | |
| 9/12 | video: mxsfb: convert to clk_prepare/clk_unprepare | +0 | 0 replies | |
| 10/12 | ASoC: mxs-saif: convert to clk_prepare/clk_unprepare | +0 | 0 replies |
Reviews trailers per patch
7 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Marek Vasut | Vinod Koul |
|---|---|---|
| 1/12 | A-b | |
| 2/12 | ||
| 2/12 | ||
| 3/12 | A-b | |
| 4/12 | A-b | A-b |
| 5/12 | A-b | |
| 6/12 | A-b | |
| 7/12 | ||
| 8/12 | ||
| 8/12 | ||
| 8/12 | ||
| 9/12 | A-b | |
| 10/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/12] Add clk_prepare/clk_unprepare for mxs clock api
Quoted 15 lines · Marek Vasut
Quoted 5 lines
Quoted 5 lines
The mutex locking problem on mxs platform has been reported on mailing list for a few time. The cause is that a mutex is being held in mxs clock api clk_enable/clk_disable which are being called by some mxs clock client drivers like amba-pl011 and mxs-saif in atomic context.
Quoted 8 lines
Quoted 5 lines
This series takes Russell's suggestion to:
* Convert all mxs clock client drivers to clk_prepare/clk_unprepare.(I hope the series has covered all the drivers, but appreciate any reminding on any missing ones.)
serial/amba-pl011.cisn't converted, that's where I originally observed the issue.
Quoted 7 lines
The amba-pl011 on mainline had already been converted by Russell. The reason we are still seeing the problem is that clk_prepare/clk_unprepare is dummy while clk_enable/clk_disable holds mutex on mxs clock api. And this series is trying to swap the their position to have the problem fixed.
You can try this series out to see if your problem goes away :)
Shawn, what exact tree should I use for the test / what branch. I'm slightly confused here. So far, I used next/master since it contained all the stuff I needed (gpmi nand etc).
Thanks!
M