tracing: make signal tracepoints more useful
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 24 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tracing: let trace_signal_generate() report more info, kill overflow_fail/lose_infoinclude/ kernel/ | +36 | 0 replies | |
| 2/2 | tracing: send_sigqueue() needs trace_signal_generate() tookernel/ | +5 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Seiji Aguchi | Steven Rostedt |
|---|---|---|
| 1/2 | R-b | A-b |
| 2/2 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] tracing: make signal tracepoints more useful
Hello.
Linus, I am asking you to review (and hopefully apply) these changes, I do not know who else can do this. I do not mean the implementation, the patches are simple. Just the behavioural change.
2/2 looks like a bugfix to me, but 1/2 changes the output from trace_signal_generate() and removes trace_signal_overflow_fail. In essence the change is:
- TP_printk("sig=%d errno=%d code=%d comm=%s pid=%d",
+ TP_printk("sig=%d errno=%d code=%d comm=%s pid=%d grp=%d res=%d",
where
- grp=0/1 means private or shared
- res is enum { TRACE_SIGNAL_DELIVERED, TRACE_SIGNAL_IGNORED, TRACE_SIGNAL_ALREADY_PENDING, TRACE_SIGNAL_OVERFLOW_FAIL, TRACE_SIGNAL_LOSE_INFO, };
Obviously this is the user visible change. But personally I do agree with Seiji who requested this feature. Currently trace_signal_generate() just records the fact that __send_signal() was called, you can't know whether the signal was actually sent or not.
include/trace/events/signal.h | 85 +++++++++++------------------------------ kernel/signal.c | 28 +++++++++---- 2 files changed, 41 insertions(+), 72 deletions(-)