Fix routing metrics
Status from this message: Applied, but I had to fixup trailing whitespace:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 2 repliesApplied
- v22 patches 2 repliesSuperseded
- v14 patches 17 repliesSuperseded
Changes in v3 from the cover letter
- Fix possible null pointer dereference in ip_rt_redirect()
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | inetpeer: Invalidate the inetpeer tree along with the routing cacheinclude/ net/ net/ | +83 | 1 reply | |
| 2/2 | route: Remove redirect_genidinclude/ net/ net/ | +2 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/2] Fix routing metrics
At the moment we initialize the routing metrics with the, on the inetpeer cached values in rt_init_metrics(). So if we have the metrics cached on the inetpeer, we ignore the user configured fib_metrics. This leads to the fact that we can't configure the mtu, hoplimit etc. if we have learned metrics cached.
The first patch invalidates the inetpeer tree along routing cache. This is done by replacing the old tree with a fresh initialized inet_peer_base when rt_cache_invalidate() is invoked. The old tree is added to a garbage collector list and destroyed later with a delayed work queue. I use a delay of 60 seconds, so rt_check_expire() ran at least on time before on a default configuration.
The second patch removes the redirect_genid handling. We don't need this any more because we remove the whole inetpeer tree when the redirects are invalidated.
Changes from v2:
- Fix possible null pointer dereference in ip_rt_redirect()