make request_module() killable
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 4 repliesIn review
Changes from the cover letter
- improve the comments a bit
- reorder the changes so that 3/6 which changes kABI can be skipped, to simplify the backporting
- tried to test, seems to work
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | usermodehelper: introduce umh_complete(sub_info)kernel/ | +7 | 0 replies | |
| 2/6 | usermodehelper: implement UMH_KILLABLEinclude/ kernel/ | +27 | 0 replies | |
| 3/6 | usermodehelper: kill umh_wait, renumber UMH_* constantsinclude/ kernel/ security/ | +10 | 2 replies | |
| 4/6 | usermodehelper: ____call_usermodehelper() doesn't need do_exit()kernel/ | +1 | 0 replies | |
| 5/6 | kmod: introduce call_modprobe() helperkernel/ | +16 | 0 replies | |
| 6/6 | kmod: make __request_module() killablekernel/ | +24 | 16 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Rusty Russell | Tejun Heo | Frederic Weisbecker | Mandeep Singh Baines | Paul E. McKenney |
|---|---|---|---|---|---|
| 1/6 | |||||
| 2/6 | |||||
| 3/6 | A-b | ||||
| 4/6 | |||||
| 5/6 | |||||
| 6/6 | A-b A-b A-b A-b | A-b | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/6] make request_module() killable
As Tetsuo pointed out, request_module() is very much unfriendly wrt OOM. It needs "a lot" of time/memory to finish while the caller is blocked in TASK_UNINTERRUPTIBLE.
Changes:
- improve the comments a bit
- reorder the changes so that 3/6 which changes kABI can be skipped, to simplify the backporting
- tried to test, seems to work
This series is orthogonal to kmod-avoid-deadlock-by-recursive-kmod-call.patch (which I still think should be replaced, I'll try to return to this later).
3/6 depends on usermodehelper-use-umh_wait_proc-consistently.patch
Many thanks to Tetsuo for the discussion.
Oleg.