mach/io.h cleanup and removal
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 15 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 15 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/15] mach/io.h cleanup and removal
Quoted 36 lines · Rob Herring
Quoted 25 lines · Arnd Bergmann
Quoted 9 lines · Tony Lindgren
Yes should be just the legacy drivers needing this for most part, so that's currently most of omap1 drivers for us.
Anyways I'm using
plat/omap-iomap.hfor the name, so if somebody has better ideas for naming to avoid further search and replace later on, let me know.I guess in the long run we could have
Quoted 7 lines
#include <
mach-omap1/iomap.h>instead of
#include <
plat/omap-iomap.h>as the plat can't be used for multi-subarch builds.
I think it /could/ be used, we just need to make a definite decision which way we want to go for header files that are defined by a platform and used by code outside of that platform such as device drivers.
The two main approaches that I can see are
Quoted 9 lines
a) make every header file name unique for platforms that you want to build together, and just add every path at the compiler command line. Not too much work, but somewhat error prone when you start having file name conflicts.
b) move all platform specific header files into a directory named after the platform and change all device drivers using this. Lots of work, but probably better in the long run.
Quoted 6 lines
c) Don't allow mach includes in drivers and sound dirs for multi-platform kernels. This is already the case for any multi-arch driver. A lot of the headers are
platform_datastructs or things that should be cleaned up or need common infrastructure. Some cases I've found seem like the include is unnecessary. Also, just fixing up the name or path is no guarantee of avoiding namespace collisions.
Out of the three options c) makes most sense for multi-subarch kernels. And that avoids having to sort out the name collisions with defines.
For dealing with legacy platforms, I too would prefer b).
Regards,
Tony