mach/io.h cleanup and removal
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 15 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 15 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/15] mach/io.h cleanup and removal
Quoted 9 lines · Tony Lindgren
Quoted 6 lines
c) Don't allow mach includes in drivers and sound dirs for multi-platform kernels. This is already the case for any multi-arch driver. A lot of the headers are
platform_datastructs or things that should be cleaned up or need common infrastructure. Some cases I've found seem like the include is unnecessary. Also, just fixing up the name or path is no guarantee of avoiding namespace collisions.Out of the three options c) makes most sense for multi-subarch kernels. And that avoids having to sort out the name collisions with defines.
I agree that this is the ideal, but as far as I can tell, we have a significant amount of functions that are defined in platform specific code but used in platform specific drivers. E.g. when you have a piece of code dealing with system management registers in your platform, that would be used in the cpufreq, irqchip, watchdog and more drivers.
There has to be some place where we can put function declarations for stuff like this, while at the same time we should try to minimise the amount that is required.
Quoted 1 line
For dealing with legacy platforms, I too would prefer b).
How about this:
* We stop providing arch/arm/{mach,plat}-*/include/ to C files outside of arch/arm/{mach,plat}-* when CONFIG_MULTIPLATFORM is enabled.
* Any symbol that is required to be visible in device drivers gets declared in arch/arm/include/mach-*/*.h, but we are very careful about adding only the absolute minimum here.
Arnd