Skip to content

ARM: OMAP: resolve some warnings

Paul Walmsley linux-arm-kernel linux-omap 2 versions – New

Get series with b4
b4 am 20120411003454.27059.37500.stgit@dusk

Versions newest first · linked by author and title

  1. v4 Latest12 patches 0 repliesNew
  2. v15 patches 0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ARM: OMAP2+: declare file-local functions as staticarch/arm/mach-omap1/fpga.c arch/arm/mach-omap1/timer.c arch/arm/mach-omap2/board-omap4panda.c +4 more+11 -121 reply
1/12ARM: OMAP2+: declare file-local functions as static+0 -00 replies
2/12ARM: OMAP: add includes for missing prototypesarch/arm/mach-omap1/common.h arch/arm/mach-omap1/id.c arch/arm/mach-omap1/io.c +10 more+19 -50 replies
3/12ARM: OMAP1: OCPI: move to mach-omap1/arch/arm/mach-omap1/Makefile arch/arm/mach-omap1/common.h arch/arm/mach-omap1/ocpi.c +1 more+10 -50 replies
4/12ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI busarch/arm/mach-omap1/usb.c arch/arm/plat-omap/include/plat/board.h drivers/usb/host/ohci-omap.c+8 -22 replies
4/12ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus+0 -00 replies
4/12ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus+0 -00 replies
5/12ARM: OMAP2+: GPMC: resolve type-conversion warning from sparsearch/arm/mach-omap2/gpmc.c+1 -20 replies
6/12ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warningsarch/arm/mach-omap1/ams-delta-fiq.c arch/arm/mach-omap1/board-palmz71.c arch/arm/mach-omap2/irq.c +1 more+6 -60 replies
7/12ARM: OMAP: OCM RAM: use memset_io() when clearing SRAMarch/arm/plat-omap/sram.c+2 -20 replies
8/12ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA codearch/arm/mach-omap1/lcd_dma.c arch/arm/plat-omap/dma.c+11 -70 replies
9/12ARM: OMAP: USB: remove unnecessary sideways includearch/arm/plat-omap/usb.c+0 -20 replies
10/12ARM: OMAP1: board files: deduplicate and clean some NAND-related codearch/arm/mach-omap1/Makefile arch/arm/mach-omap1/board-fsample.c arch/arm/mach-omap1/board-h2.c +4 more+53 -651 reply
10/12ARM: OMAP1: board files: deduplicate and clean some NAND-related code+0 -00 replies
11/12ARM: OMAP1: DMTIMER: fix broken timer clock source selectionarch/arm/mach-omap1/timer.c+2 -21 reply
11/12ARM: OMAP1: DMTIMER: fix broken timer clock source selection+0 -00 replies

Reviews trailers per patch

6 of 16 patches have a Reviewed-by or Acked-by.

PatchSantosh ShilimkarArnd BergmannFelipe Balbi
1/12A-b A-b
1/12A-b A-b
2/12A-b
3/12
4/12A-b
4/12A-b
4/12A-b
5/12
6/12
7/12
8/12
9/12
10/12
10/12
11/12
11/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] ARM: OMAP: resolve some warnings

This is the latest version of the OMAP warnings cleanup series. This version fixes most of the warnings with arch/arm/mach-omap1, arch/arm/mach-omap2, and arch/arm/plat-omap. It also fixes some bugs discovered in the process.

Boot-tested on 5912OSK, N800, 35xx BeagleBoard, 37xx EVM, and 4430 Pandaboard. Build-tested on the configs listed below, which are available from git://git.pwsan.com/omap_kconfigs.

This series is also available from git://git.pwsan.com/linux-2.6
in the branch 'sparse_cppcheck_cleanup_3.5'.

Felipe, one of the patches in this branch touches drivers/usb/host/ohci-omap.c - could you ack it for me if you are okay with the change?

- Paul

---

object size (delta in bytes from v3.4-rc2):
text data bss total kernel

  -84 	  +24 	    0 	  -60 	5912osk_testconfig/vmlinux
 -100 	   -8 	    0 	 -108 	n800_multi_omap2xxx/vmlinux
  -68 	   -8 	    0 	  -76 	n800_testconfig/vmlinux
 -224 	  +56 	  -32 	 -200 	omap1_defconfig/vmlinux
 -148 	  +32 	    0 	 -116 	omap2_4_testconfig/vmlinux
 -212 	    0 	    0 	 -212 	omap2plus_defconfig/vmlinux
 -148 	    0 	    0 	 -148 	omap2plus_no_pm/vmlinux
 -152 	    0 	    0 	 -152 	omap3_4_testconfig/vmlinux
 -100 	   -8 	    0 	 -108 	omap3_testconfig/vmlinux

-188 -24 -64 -276 omap4_testconfig/vmlinux

Paul Walmsley (12):
ARM: OMAP2+: declare file-local functions as static
ARM: OMAP: add includes for missing prototypes
ARM: OMAP1: OCPI: move to mach-omap1/
ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus
ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse
ARM: OMAP: fix 'using plain integer as NULL pointer' sparse warnings
ARM: OMAP: OCM RAM: use memset_io() when clearing SRAM
ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code
ARM: OMAP: USB: remove unnecessary sideways include
ARM: OMAP1: board files: deduplicate and clean some NAND-related code
ARM: OMAP1: DMTIMER: fix broken timer clock source selection
ARM: OMAP2+: clean up some cppcheck warnings

 arch/arm/mach-omap1/Makefile                 |   13 ++++++---
 arch/arm/mach-omap1/ams-delta-fiq.c          |    2 +
 arch/arm/mach-omap1/board-fsample.c          |   16 +----------
 arch/arm/mach-omap1/board-h2.c               |   17 +----------
 arch/arm/mach-omap1/board-h3.c               |   16 +----------
 arch/arm/mach-omap1/board-nand.c             |   39 ++++++++++++++++++++++++++
 arch/arm/mach-omap1/board-palmz71.c          |    4 +--
 arch/arm/mach-omap1/board-perseus2.c         |   16 +----------
 arch/arm/mach-omap1/clock.c                  |    3 +-
 arch/arm/mach-omap1/common.h                 |   11 +++++++
 arch/arm/mach-omap1/fpga.c                   |    2 +
 arch/arm/mach-omap1/id.c                     |    2 +
 arch/arm/mach-omap1/io.c                     |    3 +-
 arch/arm/mach-omap1/irq.c                    |    2 +
 arch/arm/mach-omap1/lcd_dma.c                |    7 +----
 arch/arm/mach-omap1/ocpi.c                   |    7 +++--
 arch/arm/mach-omap1/pm.c                     |    9 +++---
 arch/arm/mach-omap1/reset.c                  |    2 +
 arch/arm/mach-omap1/timer.c                  |    7 ++---
 arch/arm/mach-omap1/usb.c                    |    3 ++
 arch/arm/mach-omap2/am35xx-emac.c            |   37 +++++++++++--------------
 arch/arm/mach-omap2/board-omap3evm.c         |    8 +++--
 arch/arm/mach-omap2/board-omap4panda.c       |    8 +++--
 arch/arm/mach-omap2/board-rx51-peripherals.c |    4 +--
 arch/arm/mach-omap2/board-zoom-display.c     |    1 +
 arch/arm/mach-omap2/common.h                 |    2 -
 arch/arm/mach-omap2/devices.c                |    7 ++---
 arch/arm/mach-omap2/gpio.c                   |    2 +
 arch/arm/mach-omap2/gpmc-onenand.c           |    3 +-
 arch/arm/mach-omap2/gpmc.c                   |    3 +-
 arch/arm/mach-omap2/hwspinlock.c             |    2 +
 arch/arm/mach-omap2/io.c                     |    1 +
 arch/arm/mach-omap2/irq.c                    |    3 +-
 arch/arm/mach-omap2/mux.c                    |    2 +
 arch/arm/mach-omap2/omap-secure.c            |    1 +
 arch/arm/mach-omap2/omap-wakeupgen.c         |    2 +
 arch/arm/mach-omap2/pm24xx.c                 |    3 --
 arch/arm/mach-omap2/pm34xx.c                 |   10 ++-----
 arch/arm/mach-omap2/prm_common.c             |    4 ++-
 arch/arm/mach-omap2/serial.c                 |    2 +
 arch/arm/mach-omap2/usb-tusb6010.c           |    2 +
 arch/arm/plat-omap/Makefile                  |    3 --
 arch/arm/plat-omap/common.c                  |    1 +
 arch/arm/plat-omap/dma.c                     |   13 +++++++--
 arch/arm/plat-omap/dmtimer.c                 |    3 +-
 arch/arm/plat-omap/include/plat/board.h      |    2 +
 arch/arm/plat-omap/include/plat/common.h     |    2 +
 arch/arm/plat-omap/include/plat/dma.h        |    1 +
 arch/arm/plat-omap/include/plat/dmtimer.h    |    4 +--
 arch/arm/plat-omap/omap_device.c             |    2 -
 arch/arm/plat-omap/sram.c                    |    4 +--
 arch/arm/plat-omap/usb.c                     |    4 ---
 drivers/usb/host/ohci-omap.c                 |    5 ++-
 53 files changed, 165 insertions(+), 167 deletions(-)
 create mode 100644 arch/arm/mach-omap1/board-nand.c
 rename arch/arm/{plat-omap/ocpi.c => mach-omap1/ocpi.c} (93%)