Skip to content

RFC mac80211 queue redesign

Johannes Berg linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mac80211: add explicit monitor interface if neededdrivers/net/wireless/mac80211_hwsim.c include/net/mac80211.h net/mac80211/driver-ops.h +5 more+95 -62 replies
2/2mac80211: add improved HW queue controlinclude/net/mac80211.h net/mac80211/agg-tx.c net/mac80211/cfg.c +5 more+216 -282 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/2] mac80211 queue redesign

Here's the queue redesign we've been talking about.

The monitor patch is needed because when a driver actually uses the new queue feature there isn't any queue to TX frames on for purely virtual interfaces. This only affects monitor (AP_VLAN are tied to AP) and only when injecting frames that don't have a TA matching another interface (as we bind the frames to that interface then). That, however is probably the biggest use case (now that monitor-for-AP is dying). As a consequence, drivers wanting to support "pure" injection and using the new queue features need to support the pure monitor interface feature as well. Also, the pure monitor feature will help implement monitor mode on devices where that is mutually exclusive with other modes (like iwlwifi.)

The monitor feature I've tested in hwsim, it works. The queue feature isn't tested at all, I haven't even done any kind of regression tests for drivers not using it.

Thanks goes out to everybody I discussed this with (on IRC or elsewhere), and also Michal for reviewing a first version of this patch :-)

johannes