Skip to content

USB: Fix EHCI to work with data cache enabled

Marek Vasut u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled

Dear puneets,

Quoted 6 lines

Dear Marek,
After applying these 4 patches I don't see any alignment spew and it detects the
mass storage device perfectly though I see a warning "EHCI timed out on TD - token=0x80008c80"
consistently in each "usb reset".

That's something else (unrelated to this patchset), I saw it in your backlog too. Can you try debuging it on top of these patches? Because these patches fix a lot of other issues, so let's take them as a base for now. Also, did you really test dos partition table and vfat? I had to fix them to work with patches, you change to part_dos.c wasn't enough.

Quoted 43 lines

Thanx & Regards,
Puneet

Quoted 30 lines · Marek Vasut

Dear Marek Vasut,

Quoted 21 lines

This patchset reworks the USB core and EHCI-HCD to work with data caches.

Marek Vasut (3):
USB: Drop ehci_alloc/ehci_free in ehci-hcd
USB: Drop cache flush bloat in EHCI-HCD
USB: Document the QH and qTD antics in EHCI-HCD

Puneet Saxena (1):
USB: Align buffers at cacheline

  common/cmd_usb.c            |    3 +-
  common/usb.c                |   22 ++--
  common/usb_hub.c            |   27 ++--
  common/usb_storage.c        |   59 +++++-----
  disk/part_dos.c             |    2 +-
  drivers/usb/host/ehci-hcd.c |  284

++++++++++++++----------------------------- include/scsi.h |

Quoted 6 lines
   4 +-
  include/usb.h               |    4 +-
  8 files changed, 155 insertions(+), 250 deletions(-)
Cc Puneet Saxena<[email protected]>
Quoted 7 lines

Puneet, can you please test this stuff? It should fix your cache misalignment issues. Mine are now gone and USB works with caches on too.

I'd like to queue this for -next.

Best regards,
Marek Vasut

Quoted 8 lines

---------------------------------------------------------------------------
-------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
---------------------------------------------------------------------------
--------

Best regards,
Marek Vasut

Read the cover letter in its thread