cred: copy_process() should clear child->replacement_session_keyring
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | cred: copy_process() should clear child->replacement_session_keyringkernel/ | +2 | 2 replies | |
| 1/1 | task_work_queue: add generic process-context callbacksinclude/ include/ include/ +4 more | +115 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | David Howells |
|---|---|
| 1/1 | A-b |
| 1/1 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/1] cred: copy_process() should clear child->replacement_session_keyring
Hello.
Looks trivial, but I do not know how to test and I don't understand this code. David, please review ;)
Note: initially this was 1/2. The usage of >replacement_session_keyring is racy, although the problem is minor. I think that instead of fixing a lot of key_replace_session_keyring's callers in arch/ we can add the simple abstraction layer and kill ->replacement_session_keyring. I'll try to send the patches tomorrow.
Btw. exit_creds() does validate_creds(cred) right before put_cred(cred), without alter_cred_subscribers() in between this looks unneeded?
Oleg.