Add support for MINI2440 (s3c2440)
Get series with b4
b4 am 20120429213859.GA20804@debianVersions newest first
- v1 Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)
Quoted 20 lines · Wolfgang Denk
Dear Gabriel Huau,
Quoted 12 lines · In message <[email protected]> you…
Quoted 11 lines
Review
Quoted 9 lines
(quoted diff) +8
-0+/* + * When booting from NAND, it is impossible to access the lowest addresses + * due to the SteppingStone being in the way. Luckily the NOR doesn't really + * care about the highest 16 bits of address, so we set the controlers + * registers to go and poke over there, instead. + */ +#define PHYS_FLASH_1 0x0 +#define CONFIG_SYS_FLASH_BASE 0x0Urghh... this sounds very much like a serious design issue?
Quoted 4 lines
About this point, I ported it from the old version uboot as well. It may need some investigation, but I remember it was a big problem with this board. In the case of a NAND boot, we don't have access to NOR because the SteppingStone (SRAM) is mapped at the same range.
Quoted 7 lines
Should this not only affect the SPL part of the code, while you could use normal mappings for the real U-Boot.
Umm... but I don't even see any reference to SPL files here. Is this current code supposed to support NAND booting? and if so, why doesn;t it use SPL?
Nope, laters. Currently, the code is only supporting boot from NOR. Should I remove these defines ?
Quoted 9 lines
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Genitiv ins Wasser, weil's Dativ ist!