Skip to content

ext4: dio overwrite nolock

Zheng Liu linux-ext4 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesApplied
  2. v2 RFC3 patches 3 repliesSuperseded
  3. v1 RFC1 of 3 patches 0 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3ext4: split ext4_file_write into buffered IO and direct IOfs/ext4/file.c+38 -221 reply
2/3ext4: add a new flag for ext4_map_blocksfs/ext4/ext4.h fs/ext4/inode.c+51 -101 reply
3/3ext4: add dio overwrite nolockfs/ext4/file.c fs/ext4/inode.c+66 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH 0/3 v3] ext4: dio overwrite nolock

Hello list,

Here is the third version of dio overwrite nolock. In this version, I rework some codes according to Robin's reply.

This patch set can improve the performance of ext4 when the user does a dio overwrite because, when a dio overwrite occurs, we don't need to take i_mutex lock in some conditons. The condition includes the size of file doesn't be changed, and align aio. So dio write can be parallelized in these conditions.

In patch 1, ext4_file_dio_write is defined to split buffered I/O and direct I/O in ext4_file_write so that some codes can be added to check whether we can do a dio overwrite without i_mutex lock later.

In patch 2, a new flag called EXT4_GET_BLOCKS_NOLOCK and a new get_block function that is named ext4_get_block_write_nolock are defined to do a lookup to let me know whether the extent of the file at this offset has been initialized because we need to know whether a dio overwrite needs to modify the metadata of the file or not.

In patch 3, we implement dio overwrite nolock. In ext4_file_dio_write, we check whether we can do a dio overwrite without lock. Then we use 'iocb->private' to store this flag to tell ext4_ext_direct_IO to handle it because file_update_time will start a new journal and it will cause a deadlock. So we need to finish to update file time with i_mutex lock, and release lock in ext4_ext_direct_IO.

v3 <- v2:
* change the condition check of dio overwrite nolock in ext4_file_dio_write
* rename 'create' variable to 'flags' in ext4_get_block_write_nolock
* remove a duplicated if statement in ext4_ext_direct_IO

v2 <- v1:
* rebase to 3.5
* rework ext4_file_dio_write to avoid to copy vfs's code back into ext4
* add some comments to explain how to determine whether we can do a nolocking overwrite dio

Any comments are welcomed. Thanks.

Regards,
Zheng

Zheng Liu (3):
ext4: split ext4_file_write into buffered IO and direct IO
ext4: add a new flag for ext4_map_blocks
ext4: add dio overwrite nolock

 fs/ext4/ext4.h  |    2 +
 fs/ext4/file.c  |  107 +++++++++++++++++++++++++++++++++++++++++++-----------
 fs/ext4/inode.c |   76 ++++++++++++++++++++++++++++++++++-----
 3 files changed, 153 insertions(+), 32 deletions(-)