Skip to content

Cleanup tcp_try_coalesce, fix module lockup on ixgbe

Alexander Duyck netdev 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 7 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4tcp: Fix truesize accounting in tcp_try_coalescenet/ipv4/tcp_input.c+4 -65 replies
2/4tcp: Move code related to head frag in tcp_try_coalescenet/ipv4/tcp_input.c+25 -172 replies
3/4tcp: move stats merge to the end of tcp_try_coalescenet/ipv4/tcp_input.c+29 -262 replies
4/4ixgbe: Fix use after free on module removedrivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c+3 -11 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchEric DumazetAlexander Duyck
1/4A-b A-b
2/4A-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [v2 PATCH 0/4] Cleanup tcp_try_coalesce, fix module lockup on ixgbe

This set represents the original patch I had done for trying to cleanup tcp_try_coalesce broken into 3 patches. The first one illustrates how I believe we should be updating the truesize based on either the size of sk_buff in the case of head reuse, or sk_buff plus the size of the head in the case of a headlen of 0.

The other two patches go through and reorder things so there isn't as much need for gotos. I believe it makes the code much more readable since it starts at the top and finishes at the bottom instead of looping through the entire code path a few times.

The last patch addresses an issue I ran into on ixgbe. It turns out the recent HWMON patch added a but on 82598 adapters that caused the driver to get hung in module unload. I figured I would submit it directly since it is a small change to fix an issue that could have a larger impact.

On that note I am going to sleep now and will respond to any reviews and/or comments in the morning.

---

Alexander Duyck (4):
ixgbe: Fix use after free on module remove
tcp: move stats merge to the end of tcp_try_coalesce
tcp: Move code related to head frag in tcp_try_coalesce
tcp: Fix truesize accounting in tcp_try_coalesce

 drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |    4 +
 net/ipv4/tcp_input.c                           |   83 +++++++++++++-----------
 2 files changed, 49 insertions(+), 38 deletions(-)
Signature · 3 lines
Thanks,

Alex