Skip to content

ARM: omap2: GPMC cleanup

Tony Lindgren linux-arm-kernel linux-omap 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest0 of 8 patches 0 repliesNew
  2. v2 posting 2/20 of 8 patches 0 repliesSuperseded
  3. v2 posting 1/20 of 8 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 of 7 patches0 repliesSuperseded

Patches in v3 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/8] ARM: omap2: GPMC cleanup
Quoted 15 lines · Ezequiel Garcia

This patchset is v3 of the small cleanup consisting in:
* mark some functions as 'static' when appropriate
* remove an unused function from gpmc.c
* improve error messages when a CS request fails
* migrate to dev_err and dev_warn

Changes from v2:
* add a commit message to some trivial patches,
that omitted it due to author's laziness.

Changes from v1:
* fix gpmc_cs_reserved to return a boolean instead of an integer error code
* add a new patch to the patchset cleaning redundant checks

Quoted 7 lines

It has been tested on a IGEP v2 board with OneNAND, which means the gpmc-nand patch is tested by compilation only.

Altough this patchset is almost trivial,
any feedback or testing is more than welcome.

Thanks to Jon Hunter for his kind review!

Looks good to me. Jon, can you please queue all the GPMC related patches into one pull request around -rc2 time assuming no more comments?

Regards,

Tony

Quoted 19 lines

Ezequiel Garcia (8):
ARM: omap2: gpmc: Mark local scoped functions static
ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function
ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value
ARM: omap2: gpmc-nand: Print something useful on CS request failure
ARM: omap2: gpmc-onenand: Print something useful on CS request failure
ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err()
ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()
ARM: omap2: gpmc: Remove redundant chip select out of range check

 arch/arm/mach-omap2/gpmc-nand.c    |    3 ++-
 arch/arm/mach-omap2/gpmc-onenand.c |    8 +++++---
 arch/arm/mach-omap2/gpmc.c         |   27 ++++++---------------------
 arch/arm/mach-omap2/gpmc.h         |    7 -------
 4 files changed, 13 insertions(+), 32 deletions(-)
Signature · 1 line
1.7.8.6