Add support for MINI2440 (s3c2440)
Get series with b4
b4 am 20120522180443.GD9379@debianVersions newest first
- v1 Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/2] Add support for MINI2440 (s3c2440)
Hi,
I sent patches v5 and v10 and I have no more review since a few weeks, so I think it's ok now, no ?
About the comment/definitions, it has been fixed in last patches :).
Best regards,
Quoted 41 lines · Wolfgang Denk
Dear Gabriel Huau,
Quoted 1 line · In message <20120521203733.GC9379@debian> you wrote:
Is it ok ? Can we apply theses patches ?
What do you mean - unfixed?
Quoted 16 lines · Gabriel Huau
Quoted 15 lines
From the last time, I removed the patch about the PLL initialization because it's board specific. I added a new patch for s3c440 gpio driver. Now in the board file we have no more magic bloat.
Quoted 10 lines
Review
Quoted 8 lines
(quoted diff) +8
-0+/* + * When booting from NAND, it is impossible to access the lowest addresses + * due to the SteppingStone being in the way. Luckily the NOR doesn't really + * care about the highest 16 bits of address, so we set the controlers + * registers to go and poke over there, instead. + */ +#define PHYS_FLASH_1 0x0 +#define CONFIG_SYS_FLASH_BASE 0x0Urghh... this sounds very much like a serious design issue?
Quoted 4 lines
Quoted 4 lines
About this point, I ported it from the old version uboot as well. It may need some investigation, but I remember it was a big problem with this board. In the case of a NAND boot, we don't have access to NOR because the SteppingStone (SRAM) is mapped at the same range.
The comment and/or definitions are apparently broken, so they should be fixed / removed.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I will not say that women have no character; rather, they have a new one every day. -- Heine