Skip to content

Some vmevent fixes...

Anton Vorontsov linux-mm lkml 1 version In review

Get series with b4
b4 am 20120601122118.GA6128@lizard

Versions newest first

  1. v1 Latest0 of 5 patches 34 repliesIn review

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Some vmevent fixes...

On Tue, May 08, 2012 at 10:36:31AM +0300, Pekka Enberg wrote:
[...]

Quoted 4 lines
Quoted 2 lines

2) VMEVENT_ATTR_STATE_ONE_SHOT is misleading name. That is effect as edge trigger shot. not only once.

Would VMEVENT_ATTR_STATE_EDGE_TRIGGER be a better name?

[...]

Quoted 9 lines
Quoted 7 lines

4) Currently, vmstat have per-cpu batch and vmstat updating makes 3 second delay at maximum.
A This is fine for usual case because almost userland watcher only read /proc/vmstat per second.
A But, for vmevent_fd() case, 3 seconds may be unacceptable delay. At worst, 128 batch x 4096
A x 4k pagesize = 2G bytes inaccurate is there.

That's pretty awful. Anton, Leonid, comments?

[...]

Quoted 5 lines
Quoted 3 lines

5) __VMEVENT_ATTR_STATE_VALUE_WAS_LT should be removed from userland exporting files.
A When exporing kenrel internal, always silly gus used them and made unhappy.

Agreed. Anton, care to cook up a patch to do that?

KOSAKI-San, Pekka,

Much thanks for your reviews!

These three issues should be fixed by the following patches. One mm/ change is needed outside of vmevent...

And I'm looking into other issues you pointed out...

Thanks!

---
 include/linux/vmevent.h |   10 +++----
 include/linux/vmstat.h  |    2 ++
 mm/vmevent.c            |   66 +++++++++++++++++++++++++++++------------------
 mm/vmstat.c             |   22 +++++++++++++++-
 4 files changed, 68 insertions(+), 32 deletions(-)
Signature · 9 lines
Anton Vorontsov
Email: [email protected]

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Read the cover letter in its thread