Skip to content

uprobes: write_opcode() cleanups

Oleg Nesterov lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 13 repliesIn review
  2. v15 patches 4 repliesSuperseded

Changes from the cover letter

- document the new argument in 2/5.

- drop the buggy 5/5, thanks Anton for your quick nack. Probably I'll return to this later, I have another reason for this change.

- so this 5/5 is new.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5uprobes: don't recheck vma/f_mapping in write_opcode()kernel/events/uprobes.c+1 -181 reply
2/5uprobes: __replace_page() should not use page_address_in_vma()kernel/events/uprobes.c+4 -72 replies
3/5uprobes: kill write_opcode()->lock_page(new_page)kernel/events/uprobes.c+0 -21 reply
4/5uprobes: cleanup and document write_opcode()->lock_page(old_page)kernel/events/uprobes.c+14 -131 reply
5/5uprobes: __replace_page() needs munlock_vma_page()kernel/events/uprobes.c+6 -22 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchSrikar Dronamraju
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] uprobes: write_opcode() cleanups

Hello,

write_opcode() cleanups resend + new minor fix.

Changes:

- document the new argument in 2/5.

- drop the buggy 5/5, thanks Anton for your quick nack. Probably I'll return to this later, I have another reason for this change.

- so this 5/5 is new.

Srikar, please add your acks unless you have some objections.

Oleg.