Skip to content

gtk+: fix build issue by not building demo programs

Apelete Seketeli openembedded-devel 1 version In review

Get series with b4
b4 am 20120619214933.GG4845@hermes

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gtk+: Rebase gtk+-2.20.1/no-demos.patchrecipes/gtk+/gtk+-2.20.1/no-demos.patch+4 -30 replies
2/2gtk+: Add no-test-inline-pixbufs.patch to gtk+-2.20.1recipes/gtk+/gtk+-2.20.1/no-test-inline-pixbufs.patch recipes/gtk+/gtk+_2.20.1.bb+23 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [oe-classic][gtk+][PATCH v2 0/2] gtk+: fix build issue by not building demo programs

Hello,

Here is another attempt to fix the following build issue:

| Making all in demos
| make[2]: Entering directory `/home/apelete/devel/bitbake/build/tmp/work/mipsel-oe-linux/gtk+-2.20.1-r10.4/gtk+-2.20.1/demos'
| /usr/bin/gdk-pixbuf-csource --raw --build-list		\
| 	        apple_red  ./apple-red.png	\
|                 gnome_foot ./gnome-foot.png	\
|         > test-inline-pixbufs.h				\
| 	|| (rm -f test-inline-pixbufs.h && false)
| failed to load "./apple-red.png": Couldn't recognize the image file format for file './apple-red.png'
| make[2]: *** [test-inline-pixbufs.h] Error 1
| make[2]: Leaving directory `/home/apelete/devel/bitbake/build/tmp/work/mipsel-oe-linux/gtk+-2.20.1-r10.4/gtk+-2.20.1/demos'
| make[1]: *** [all-recursive] Error 1
| make[1]: Leaving directory `/home/apelete/devel/bitbake/build/tmp/work/mipsel-oe-linux/gtk+-2.20.1-r10.4/gtk+-2.20.1'
| make: *** [all] Error 2

As a solution, I chose to discard the build of all the demo programs by removing the corresponding build instructions in demos/Makefile.am in the source package.
Do we really need those demo programs when building for an embedded target ?

I also jumped on the occasion to rebase the no-demos.patch that was applied to gtk+-native only (patch which intentionally disable the demo prgrams for gtk+-native, but not for target).

The two patches that come as a follow-up of this message are what it's all about.

Apelete Seketeli (2):
gtk+: Rebase gtk+-2.20.1/no-demos.patch gtk+: Add no-test-inline-pixbufs.patch to gtk+-2.20.1

 recipes/gtk+/gtk+-2.20.1/no-demos.patch            |    7 ++++---
 .../gtk+/gtk+-2.20.1/no-test-inline-pixbufs.patch  |   22 ++++++++++++++++++++
 recipes/gtk+/gtk+_2.20.1.bb                        |    1 +
 3 files changed, 27 insertions(+), 3 deletions(-)
 create mode 100644 recipes/gtk+/gtk+-2.20.1/no-test-inline-pixbufs.patch
Signature · 5 lines
1.7.10


-- 
        Apelete