Skip to content

v2 Improvements to rcu_barrier() and RT response on big systems

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22rcu: Control RCU_FANOUT_LEAF from boot-time parameterDocumentation/kernel-parameters.txt kernel/rcutree.c kernel/rcutree.h +2 more+104 -254 replies
2/22rcu: Four-level hierarchy is no longer experimentalkernel/rcutree_plugin.h+1 -10 replies
3/22rcu: Size rcu_node tree from nr_cpu_ids rather than NR_CPUSkernel/rcutree.c kernel/rcutree_plugin.h+3 -10 replies
4/22rcu: Prevent excessive line length in RCU_STATE_INITIALIZER()kernel/rcutree.c+7 -70 replies
5/22rcu: Place pointer to call_rcu() in rcu_data structurekernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+17 -170 replies
6/22rcu: Move _rcu_barrier()'s rcu_head structures to rcu_data structureskernel/rcutree.c kernel/rcutree.h+5 -40 replies
7/22rcu: Move rcu_barrier_cpu_count to rcu_state structurekernel/rcutree.c kernel/rcutree.h+15 -110 replies
8/22rcu: Move rcu_barrier_completion to rcu_state structurekernel/rcutree.c kernel/rcutree.h+5 -50 replies
9/22rcu: Move rcu_barrier_mutex to rcu_state structurekernel/rcutree.c kernel/rcutree.h+4 -60 replies
10/22rcu: Remove needless initializationkernel/rcutree.c+0 -20 replies
11/22rcu: Increase rcu_barrier() concurrencykernel/rcutree.c kernel/rcutree.h+37 -10 replies
12/22rcu: Add tracing for _rcu_barrier()include/trace/events/rcu.h kernel/rcutree.c+73 -10 replies
13/22rcu: Add rcu_barrier() statistics to debugfs tracingkernel/rcutree_trace.c+39 -00 replies
14/22rcu: Remove unneeded __rcu_process_callbacks() argumentkernel/rcutree.c kernel/rcutree_plugin.h+5 -60 replies
15/22rcu: Introduce for_each_rcu_flavor() and use itkernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+37 -1440 replies
16/22rcu: Use for_each_rcu_flavor() in TREE_RCU tracingkernel/rcutree_trace.c+43 -730 replies
17/22rcu: RCU_SAVE_DYNTICK code no longer ever deadkernel/rcutree.c+0 -20 replies
18/22rcu: Move RCU grace-period initialization into a kthreadkernel/rcutree.c kernel/rcutree.h+130 -640 replies
19/22rcu: Allow RCU grace-period initialization to be preemptedkernel/rcutree.c+10 -70 replies
20/22rcu: Move RCU grace-period cleanup into kthreadkernel/rcutree.c+62 -500 replies
21/22rcu: Allow RCU grace-period cleanup to be preemptedkernel/rcutree.c+5 -60 replies
22/22rcu: Prevent offline CPUs from executing RCU core codekernel/rcutree.c+2 -00 replies

Reviews trailers per patch

9 of 22 patches have a Reviewed-by or Acked-by.

PatchJosh Triplett
1/22
2/22
3/22
4/22R-b
5/22R-b
6/22R-b
7/22R-b
8/22R-b
9/22
10/22
11/22
12/22R-b
13/22R-b
14/22R-b
15/22
16/22
17/22R-b
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/22] v2 Improvements to rcu_barrier() and RT response on big systems

Hello!

This patch series contains improvements to the rcu_barrier() family of primitives and to latency for large systems. These are in a single series due to conflicts that would otherwise occur. This is an update from version 1 posted at: https://lkml.org/lkml/2012/6/15/509.
The individual patches are as follows:

1. Allow the value for RCU_FANOUT_LEAF to be increased (but not
decreased!) via a boot-time parameter, in turn allowing a default kernel build to be adjusted for low RCU grace-period initialization latency on a large system.
2. Stop flagging a four-level rcu_node hierarchy as "experimental".
3. Work around the new default NR_CPUS=4096 by checking the
boot-time-computed nr_cpu_ids, allowing this to override NR_CPUS. This again reduces RCU grace-period initialization latency for kernels built with large NR_CPUS running on small systems.
4. Shrink a macro argument to keep lines under 80 characters.
5. Add a pointer in the rcu_state structure to the corresponding
member of the call_rcu() family of functions in preparation for increasing rcu_barrier() concurrency.
6. Move _rcu_barrier()'s rcu_head structures to the per-CPU
per-RCU-flavor rcu_data structures so that different flavors of rcu_barrier() do not need to contend for the rcu_head structures.
7. Move rcu_barrier()'s rcu_barrier_cpu_count global variable to
a new ->barrier_cpu_count field in the rcu_state structure, so that different flavors of rcu_barrier() do not need to contend for this variable.
8. Move rcu_barrier()'s rcu_barrier_completion global variable to
a new ->barrier_completion field in the rcu_state structure, so that different flavors of rcu_barrier() do not need to contend for this variable.
9. Move rcu_barrier()'s rcu_barrier_mutex global variable to

	a new ->barrier_mutex field in the rcu_state structure, so that
	different flavors of rcu_barrier() do not need to contend for
	this variable.
10.	Remove redundant initialization to zero of the rcu_state structure's
	->n_force_qs and ->n_force_qs_ngp fields.

11. Introduce counter scheme to allow multiple concurrent executions
of a given flavor of rcu_barrier() to share work.
12. Add event tracing for _rcu_barrier().
13. Add debugfs tracing for _rcu_barrier().
14. Remove unnecessary per-CPU variable argument from

	__rcu_process_callbacks().

15. Introduce for_each_rcu_flavor() iterator and use it. This provides
a nicer way to iterate through the RCU flavors to do per-flavor processing.
16. Apply the for_each_rcu_flavor() iterator to debugfs tracing.
17. Remove dead-code gcc helper from code that is no longer ever dead.
18. Move RCU grace-period initialization into a kthread.
19. Allow RCU grace-period initialization to be preempted, including
cond_resched() preemption points for CONFIG_PREEMPT=n systems.
20. Move RCU grace-period cleanup into a kthread.
21. Allow RCU grace-period cleanup to be preempted, including
cond_resched() preemption points for CONFIG_PREEMPT=n systems.
22. Prevent offline CPUs from executing RCU core code.

Changes from version 1:

o Apply review comments from Josh Triplett and Steven Rostedt.
o Added patches 18-22 to reduce scheduling-latency spikes from
RCU initialization and cleanup on large systems.

Thanx, Paul

 b/Documentation/kernel-parameters.txt |    5 
 b/include/trace/events/rcu.h          |   45 ++
 b/kernel/rcutree.c                    |   97 +++++
 b/kernel/rcutree.h                    |   23 -
 b/kernel/rcutree_plugin.h             |    2 
 b/kernel/rcutree_trace.c              |    2 
 kernel/rcutree.c                      |  555 +++++++++++++++++++++-------------
 kernel/rcutree.h                      |   25 +
 kernel/rcutree_plugin.h               |  128 -------
 kernel/rcutree_trace.c                |  155 +++++----
 10 files changed, 604 insertions(+), 433 deletions(-)