Skip to content

Make XPS usable within ixgbe

Alexander Duyck netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 7 repliesIn review
  2. v1 RFC10 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net: Split core bits of netdev_pick_tx into __netdev_pick_txinclude/linux/netdevice.h net/core/dev.c+33 -250 replies
2/10net: Add functions netif_reset_xps_queue and netif_set_xps_queueinclude/linux/netdevice.h net/core/dev.c net/core/net-sysfs.c+173 -1430 replies
3/10net: Rewrite netif_reset_xps_queue to allow for better code reusenet/core/dev.c+33 -230 replies
4/10net: Rewrite netif_set_xps_queues to address several issuesnet/core/dev.c+117 -660 replies
5/10net: Add support for XPS without sysfs being definedinclude/linux/netdevice.h net/Kconfig net/core/dev.c +1 more+21 -220 replies
6/10ixgbe: Define FCoE and Flow director limits much sooner to allow for changesdrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+9 -100 replies
7/10ixgbe: Add function for setting XPS queue mappingdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+20 -50 replies
8/10ixgbe: Update ixgbe driver to use __netdev_pick_tx in ixgbe_select_queuedrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+26 -220 replies
9/10ixgbe: Add support for displaying the number of Tx/Rx channelsdrivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c+72 -00 replies
10/10ixgbe: Add support for set_channels ethtool operationdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+46 -36 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/10] Make XPS usable within ixgbe

The following patch series makes it so that the ixgbe driver can support ATR even when the number of queues is less than the number of CPUs. To do this I have updated the kernel to support letting drivers set their own XPS configuration. To do this it was necessary to move the code out of the sysfs specific code and into the dev specific regions.

It has been almost 6 months since the last time I released these patches. I have been meaning to get back to them but I just haven't had a chance to get this work done until recently.

Only the core net patches are meant for acceptance at this time. I will submit the ixgbe patches through Jeff Kirsher's tree. For this reason I have tagged the ixgbe related patches as RFC.

---

rc2: Updated first patch to address changes from dev_pick_tx to netdev_pick_tx.
Made it so that we only update XPS map on queue number change. Minor tweaks and cleanups to get caught up with recent changes in the tree.

Alexander Duyck (10):
net: Split core bits of netdev_pick_tx into __netdev_pick_tx
net: Add functions netif_reset_xps_queue and netif_set_xps_queue
net: Rewrite netif_reset_xps_queue to allow for better code reuse
net: Rewrite netif_set_xps_queues to address several issues
net: Add support for XPS without sysfs being defined
ixgbe: Define FCoE and Flow director limits much sooner to allow for changes
ixgbe: Add function for setting XPS queue mapping
ixgbe: Update ixgbe driver to use __netdev_pick_tx in ixgbe_select_queue
ixgbe: Add support for displaying the number of Tx/Rx channels
ixgbe: Add support for set_channels ethtool operation

 drivers/net/ethernet/intel/ixgbe/ixgbe.h         |    3 
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |  112 +++++++++
 drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c     |   21 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |   77 ++++--
 include/linux/netdevice.h                        |   13 +
 net/Kconfig                                      |    2 
 net/core/dev.c                                   |  289 ++++++++++++++++++++--
 net/core/net-sysfs.c                             |  160 ------------
 8 files changed, 454 insertions(+), 223 deletions(-)