RFC optimize detection of MD devices
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/3] optimize detection of MD devices
Hi Alasdair,
Quoted 4 lines · Alasdair G Kergon
Quoted 1 line · dongsu.park at profitbricks.com
This patchset optimizes the detection mechanism of MD devices, as well
Optimising the detection, good.
Thank you for reviewing the patches.
Quoted 11 lines
Quoted 2 lines
as introduces a possibility to turn off detections of the legacy metadata versions.
Maybe, but I'd discourage people from turning it off more strongly, as it's a small price to pay for peace of mind.
So, after review and a bit of tweaking, yes, I'm in favour.
However, the whole of this code is itself 'legacy' in that this detection is moving into blkid under udev's control, so you should check if that code is sufficiently efficient too.
Ok, that's a good point.
It would be more optimal to get MD metadata versions, rather than to turn off v1.0/v0.9 completely.
I think it could be possible to determine the MD metadata version of a device, simply reading the sysfs attribute,
e.g. /sys/block/md*/md/metadata_version.
I'll post a second patchset with the improvement.
Dongsu
Quoted 3 lines
Alasdair