Skip to content

OLPC: create a generic OLPC EC driver

Andres Salomon linux-wireless lkml netdev platform-driver-x86 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/29 patches 1 replyIn review
  2. v1 posting 1/20 of 9 patches 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Platform: OLPC: add a stub to drivers/platform/ for the OLPC EC driverarch/x86/include/asm/olpc.h arch/x86/platform/olpc/olpc.c drivers/platform/Makefile +2 more+51 -180 replies
2/9drivers: OLPC: update various drivers to include olpc-ec.harch/x86/include/asm/olpc.h arch/x86/platform/olpc/olpc-xo1-pm.c arch/x86/platform/olpc/olpc-xo1-sci.c +6 more+8 -30 replies
3/9Platform: OLPC: allow EC cmd to be overridden, and create a workqueue to call itdrivers/platform/olpc/olpc-ec.c include/linux/olpc-ec.h+116 -20 replies
4/9Platform: OLPC: turn EC driver into a platform_driverdrivers/platform/olpc/olpc-ec.c include/linux/olpc-ec.h+54 -00 replies
5/9Platform: OLPC: add a suspended flag to the EC driverdrivers/platform/olpc/olpc-ec.c+45 -10 replies
6/9x86: OLPC: switch over to using new EC driver on x86arch/x86/include/asm/olpc.h arch/x86/platform/olpc/olpc.c drivers/platform/olpc/olpc-ec.c+27 -360 replies
7/9Platform: OLPC: move debugfs support from x86 EC driverarch/x86/platform/olpc/olpc.c drivers/platform/olpc/olpc-ec.c+117 -970 replies
8/9Platform: OLPC: move global variables into priv structdrivers/platform/olpc/olpc-ec.c+28 -200 replies
9/9x86: OLPC: move s/r-related EC cmds to EC driverarch/x86/platform/olpc/olpc-xo1-pm.c arch/x86/platform/olpc/olpc.c+36 -220 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThomas Gleixner
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RESEND 0/9] OLPC: create a generic OLPC EC driver

The OLPC EC (Embedded Controller) code that is currently upstream is x86-only, originally written for the XO-1. Since then, we've had the XO-1.5 (also x86), and XO-1.75 (arm-based) enter mass production. The 1.75 uses a vastly different EC protocol, and future hardware revisions are likely to change it even further.

However, the drivers do share quite a bit of code, so it makes sense to have a platform-agnostic driver that calls into platform-specific hooks for each XO's EC driver. This is the first stab and creating such a beast (with further patches pending). Aside from the lack of code duplication, this is helpful for fixing bugs in one place (for example, we fixed an EC suspend/resume bug in 1.75 that I've just seen happen on 1.5 without these patches. With these patches, the problem goes away).

These patches are against Linus's current HEAD; let me know if they don't apply somewhere, and I'll happily redo them against the -next tree. I'm assuming that these changes (which touch places like x86, wireless, and staging) should go through either the x86 tree, or through akpm's tree.

Alternatively, if the reviews are positive and I can get SOBs from the relevant maintainers, I can set up a platform-olpc tree somewhere and request a pull from Linus.