Skip to content

Get rid of FIQ_START/enable/disable_fiq() + some FIQ cleanups

Anton Vorontsov linux-arm-kernel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 3/310 patches 7 repliesIn review
  2. v1 posting 2/310 patches 3 repliesSuperseded
  3. v1 posting 1/39 patches 17 repliesSuperseded

Patches in v1 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ARM: mach-rpc: Don't register FIQs with genirqarch/arm/mach-rpc/dma.c arch/arm/mach-rpc/include/mach/irqs.h arch/arm/mach-rpc/irq.c+11 -170 replies
2/10ARM: plat-s3c24xx: Don't use FIQ_STARTarch/arm/plat-s3c24xx/irq.c+1 -10 replies
3/10mx1_camera: Don't use {en,dis}able_fiq() callsdrivers/media/platform/soc_camera/mx1_camera.c+3 -30 replies
4/10ASoC: imx: Don't use {en,dis}able_fiq() callssound/soc/fsl/imx-pcm-fiq.c+2 -20 replies
5/10ARM: FIQ: Remove enable_fiq() and disable_fiq() callsarch/arm/include/asm/fiq.h arch/arm/kernel/fiq.c+0 -170 replies
6/10ARM: FIQ: Remove FIQ_STARTarch/arm/include/asm/mach/irq.h arch/arm/kernel/fiq.c arch/arm/mach-omap1/include/mach/irqs.h +7 more+6 -200 replies
7/10ARM: FIQ: Should include asm/mach/irq.harch/arm/kernel/fiq.c+1 -00 replies
8/10ARM: FIQ: Implement !CONFIG_FIQ stubsarch/arm/include/asm/mach/irq.h arch/arm/kernel/irq.c arch/arm/plat-mxc/avic.c +2 more+5 -80 replies
9/10ARM: FIQ: Make show_fiq_list() return voidarch/arm/include/asm/mach/irq.h arch/arm/kernel/fiq.c+3 -50 replies
10/10ARM: FIQ: Get rid of init_FIQ()arch/arm/include/asm/mach/irq.h arch/arm/kernel/fiq.c arch/arm/mach-rpc/irq.c +3 more+8 -217 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchKukjin KimSascha HauerMark Brown
1/10
2/10A-b
3/10A-b
4/10A-b A-b
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH resend 0/10] Get rid of FIQ_START/enable/disable_fiq() + some FIQ cleanups

Hello Andrew, Russell,

These are small cleanups that I keep resending since Aug. Andrew, can you please take them for the time being?

The rationale is the same:

During KDB FIQ patches review Russell mentioned that I should not introduce another FIQ_START. It seems that in v3.6-rc the FIQ_START issue was somewhat band-aided, i.e. machines don't necessary need to define this stuff any longer, but I also read the background of the issue, and Russell once said that he don't want the FIQ subsystem to mess with genirq.

So, the patch set is pretty straightforward:

- Get rid of FIQ_START. Nobody but platform-specific code (and platform-specific drivers) should know the details about which interrupt can be routed to FIQ and which cannot;

- Remove disable/enable_fiq() calls from the FIQ subsys.

Thanks!

--

 arch/arm/include/asm/fiq.h                    |  2 -
 arch/arm/include/asm/mach/irq.h               |  7 +++-
 arch/arm/kernel/fiq.c                         | 37 +++++--------------
 arch/arm/kernel/irq.c                         |  2 -
 arch/arm/mach-omap1/include/mach/irqs.h       |  4 --
 arch/arm/mach-rpc/dma.c                       |  4 +-
 arch/arm/mach-rpc/include/mach/irqs.h         |  8 ++--
 arch/arm/mach-rpc/irq.c                       | 21 ++---------
 arch/arm/mach-s3c24xx/include/mach/irqs.h     |  3 --
 arch/arm/plat-mxc/avic.c                      |  5 ---
 arch/arm/plat-mxc/include/mach/irqs.h         |  2 -
 arch/arm/plat-mxc/tzic.c                      |  5 ---
 arch/arm/plat-s3c24xx/irq.c                   |  6 +--
 .../media/platform/soc_camera/mx1_camera.c    |  6 +--
 sound/soc/fsl/imx-pcm-fiq.c                   |  4 +-
 15 files changed, 31 insertions(+), 85 deletions(-)