Skip to content

uprobes: kill uprobes_state->count, add MMF_HAS_UPROBES

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7uprobes: kill uprobes_state->countinclude/linux/uprobes.h kernel/events/uprobes.c+3 -371 reply
2/7uprobes: kill dup_mmap()->uprobe_mmap(), simplify uprobe_mmap/munmapkernel/events/uprobes.c kernel/fork.c+3 -301 reply
3/7uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending()kernel/events/uprobes.c+6 -211 reply
4/7uprobes: do not use -EEXIST in install_breakpoint() pathskernel/events/uprobes.c+5 -111 reply
5/7uprobes: introduce MMF_HAS_UPROBESinclude/linux/sched.h include/linux/uprobes.h kernel/events/uprobes.c +1 more+29 -13 replies
6/7uprobes: fold uprobe_reset_state() into uprobe_dup_mmap()include/linux/uprobes.h kernel/events/uprobes.c kernel/fork.c+2 -141 reply
7/7uprobes: remove "verify" argument from set_orig_insn()include/linux/uprobes.h kernel/events/uprobes.c+10 -121 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchSrikar Dronamraju
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] uprobes: kill uprobes_state->count, add MMF_HAS_UPROBES

Hello.

Srikar, please review.

This is the first part. The next series will teach uprobes to clear MMF_HAS_UPROBES, but perhaps we should simply remove uprobe_munmap() instead. A wrong MMF_HAS_UPROBES doesn't hurt unless the task hits the non-uprobe "int3", not sure it really makes sense to try to speedup this case. We will see.

7/7 is offtopic.

Oleg.

 include/linux/sched.h   |    2 +
 include/linux/uprobes.h |   13 ++--
 kernel/events/uprobes.c |  141 ++++++++++++----------------------------------
 kernel/fork.c           |    6 +--
 4 files changed, 47 insertions(+), 115 deletions(-)