Skip to content

: arm: Provide lowlevel_init C function wrapper for v7

Allen Martin u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2omap4/5/am33xx: Make lowlevel_init available to all armv7 platforms+0 -00 replies
2/2armv7: Make lowlevel_init.S's lowlevel_init do ABI compatible stack+0 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchAllen Martin
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7
Quoted 18 lines · Tom Rini

Hey all,

As Allen Martin noted, on tegra platforms a bug is exposed when using certain toolchains that currently calls to lowlevel_init must be calls to another assembly function as the stack is not explicitly setup / saved and thus register corruption can occur. Over in TI-land Aneesh V wrote a lowlevel_init that sets up the stack and calls s_init which is a C function that does what lowlevel_init does on other platforms. The code is generic to at least v7, so this series moves it to arch/arm/cpu/armv7. The initial version of the code made use of LOW_LEVEL_SRAM_STACK as the stack to be setup. This define is essentially another name for CONFIG_SYS_INIT_SP_ADDR without taking GENERATED_GBL_DATA_SIZE into consideration. So we switch to that instead. Finally, Wolfgang question me as to if the stack really only needed the alignment that we had been giving it. To be safe, I grabbed the alignmnet that we do when setting up the initial stack for real and placed it into lowlevel_init as well.

Quoted 2 lines

Tested on AM335x GP EVM and OMAP4 Pandaboard ES2.

Converted tegra to use the new lowlevel_init wrapper and tested on seaboard. Verified it works with the previously failing CodeSourcery 2011.09-70 toolchain.

I'll respin my tegra SPL series to depend on these.

-Allen

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------