Skip to content

ipvs: IPv6 fragment handling for IPVS

Jesper Dangaard Brouer lvs-devel netdev netfilter-devel 3 versions – In review

Get series with b4
b4 am 20120926120534.24804.78415.stgit@dragon

Versions newest first · linked by author and title

  1. v4 Latest7 patches 3 repliesIn review
  2. v38 patches 3 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ipvs: Trivial changes, use compressed IPv6 address in outputinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_core.c net/netfilter/ipvs/ip_vs_proto.c +2 more+11 -110 replies
2/7ipvs: IPv6 extend ICMPv6 handling for future typesnet/netfilter/ipvs/ip_vs_core.c+2 -60 replies
3/7ipvs: Use config macro IS_ENABLED()include/net/ip_vs.h+1 -10 replies
4/7ipvs: Fix faulty IPv6 extension header handling in IPVSinclude/net/ip_vs.h net/netfilter/ipvs/Kconfig net/netfilter/ipvs/ip_vs_core.c +10 more+214 -1530 replies
5/7ipvs: Complete IPv6 fragment handling for IPVSinclude/net/ip_vs.h net/netfilter/ipvs/Kconfig net/netfilter/ipvs/ip_vs_conn.c +2 more+164 -360 replies
6/7ipvs: API change to avoid rescan of IPv6 exthdrinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_conn.c net/netfilter/ipvs/ip_vs_core.c +6 more+175 -2290 replies
7/7ipvs: SIP fragment handlingnet/netfilter/ipvs/ip_vs_pe_sip.c+15 -41 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJulian Anastasov
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/7] ipvs: IPv6 fragment handling for IPVS

The following patchset implement IPv6 fragment handling for IPVS.

This work is based upon patches from Hans Schillstrom. I have taken over the patchset, in close agreement with Hans, because he don't have (gotten allocated) time to complete his work.

I have cleaned up the patchset significantly, and split the patchset up into seven patches.

The first 3 patches, are ready to be merged

Patch01: Trivial changes, use compressed IPv6 address in output
Patch02: IPv6 extend ICMPv6 handling for future types
Patch03: Use config macro IS_ENABLED()

The next 4 patches, is V4 of the patches I have submitted earlier. Where I have incorporated Julian's recent feedback.

- Notice that patch04 of patchset V3, have been dropped.

I have also tried to make the patches easier to review, by reorganizing the changes, to be more strictly split (exthdr vs. fragment handling).

I have also removed the API changes, and moved those to patch06. This is done, (1) to make it easier to review the patches, and (2) to allow easier integration of Patricks idea and my RFC patch of caching exthdr info in skb->cb[]. Thus, we can get these patches applied (and later go back and apply the caching scheme easier).

Patch04: Fix faulty IPv6 extension header handling in IPVS
Patch05: Complete IPv6 fragment handling for IPVS
Patch06: IPVS API change to avoid rescan of IPv6 exthdr
Patch07: IPVS SIP fragment handling

The SIP frag handling have been split into its own patch, as I have not been able to test this part my self.

This patchset is based upon:
Pablo's nf-next tree: git://1984.lsi.us.es/nf-next
On top of:
commit 2cbc78a29e76a2e92c172651204f3117491877d2 (netfilter: combine ipt_REDIRECT and ip6t_REDIRECT)

---

Jesper Dangaard Brouer (7):
ipvs: SIP fragment handling
ipvs: API change to avoid rescan of IPv6 exthdr
ipvs: Complete IPv6 fragment handling for IPVS
ipvs: Fix faulty IPv6 extension header handling in IPVS
ipvs: Use config macro IS_ENABLED()
ipvs: IPv6 extend ICMPv6 handling for future types
ipvs: Trivial changes, use compressed IPv6 address in output

 include/net/ip_vs.h                     |  194 +++++++++++----
 net/netfilter/ipvs/Kconfig              |    7 -
 net/netfilter/ipvs/ip_vs_conn.c         |   15 -
 net/netfilter/ipvs/ip_vs_core.c         |  404 +++++++++++++++++--------------
 net/netfilter/ipvs/ip_vs_dh.c           |    2 
 net/netfilter/ipvs/ip_vs_lblc.c         |    2 
 net/netfilter/ipvs/ip_vs_lblcr.c        |    2 
 net/netfilter/ipvs/ip_vs_pe_sip.c       |   21 +-
 net/netfilter/ipvs/ip_vs_proto.c        |    6 
 net/netfilter/ipvs/ip_vs_proto_ah_esp.c |    9 -
 net/netfilter/ipvs/ip_vs_proto_sctp.c   |   42 +--
 net/netfilter/ipvs/ip_vs_proto_tcp.c    |   40 +--
 net/netfilter/ipvs/ip_vs_proto_udp.c    |   41 +--
 net/netfilter/ipvs/ip_vs_sched.c        |    2 
 net/netfilter/ipvs/ip_vs_sh.c           |    2 
 net/netfilter/ipvs/ip_vs_xmit.c         |   73 +++---
 net/netfilter/xt_ipvs.c                 |    4 
 17 files changed, 504 insertions(+), 362 deletions(-)

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer