*** SUBJECT HERE ***
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest1 of 11 patches 0 repliesNew
- v14 of 13 patches 0 repliesSuperseded
1 of 11 patches is in this archive. The cover letter announces 11.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | Blackfin: bf60x: new processor header files | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH v2 00/11] *** SUBJECT HERE ***
Dear Sonic Zhang,
please provide a useful Subject: line - "*** SUBJECT HERE ***" is not exactly helpful.
Quoted 3 lines · In message <[email protected]> you wrote:
The v2 patches
1) fix most checkpatch issues mentioned by Wolfgang
Hm... I'm sorry, but this information is not really helpful. So it seems you decided not to fix all issues, but you don't tell us which ones you ignored, or why.
I still see thousands of lines over 80 characters, plus a number of
trailing statements should be on next line, code indent should use tabs where possible, do not add new typedefs,
Whitespace before semicolon,
warnings and errors.
Please fix these!!
Quoted 7 lines
2) remove unrelated dma structure change patch
3) replace unreable macro in dma and uart structures with normal types.
4) replace unreable macro in uart peripheral portmux configuration with clear inline function.
5) clean up and merge redundant #ifdef's
6) spearate declarations and code by a blankline
7) remove the values for variables in blackfin config headers whose values are useless
8) replace run-time variable with new macro when adding 4M byte CPLB entries.
Please provide a more detailed list which review comments you processed, and which you decided to ignore, and why.
Please provide a more detailed list which review comments you processed, and which you decided to ignore, and why.
Note: this history of changes is supposed to be (also) in the patches itself, not (only) in the cover letter.
Thanks.
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You don't get paid for the hour. You get paid for the value you bring to the hour. - Jim Rohn