uprobes: single-step fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 18 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | uprobes: Introduce arch_uprobe_enable/disable_step()include/ kernel/ | +14 | 1 reply | |
| 2/7 | uprobes: x86: Implement x86 specific arch_uprobe_*_steparch/ arch/ | +35 | 1 reply | |
| 3/7 | ptrace: Introduce set_task_blockstep() helperarch/ | +21 | 1 reply | |
| 4/7 | ptrace: Partly fix set_task_blockstep()->update_debugctlmsr() logicarch/ | +13 | 4 replies | |
| 5/7 | uprobes: Do not (ab)use TIF_SINGLESTEP/user_*_single_step() for single-steppingarch/ arch/ arch/ | +21 | 3 replies | |
| 6/7 | uprobes: Xol should send SIGTRAP if X86_EFLAGS_TF was setarch/ arch/ | +14 | 2 replies | |
| 7/7 | uprobes: Make arch_uprobe_task->saved_trap_nr "unsigned int"arch/ | +1 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Srikar Dronamraju |
|---|---|
| Series | A-b |
| 1/7 | A-b |
| 2/7 | A-b |
| 3/7 | A-b |
| 4/7 | |
| 5/7 | A-b |
| 6/7 | A-b |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] uprobes: single-step fixes
Hello.
In short: uprobes should not use user_enable/disable_single_step(). This is unneeded and wrong.
Sebastian, I changed your patches a bit:
1/7:
- Change the subject and update the changelog. In particular, s/utrace/uprobes/. I am wondering where this typo came from ;)
2/7:
- Rename UPROBE_TF_CHANGES to UPROBE_FIX_SETF to match other *_FIX_* defines.
- Update the changelog.
- !!!REMOVE send_sig(SIGTRAP) from arch_uprobe_disable_step!!! Didn't I ask you to make a separate patch for this change? ;)
This "else send_sig(SIGTRAP)" is very wrong. Just suppose an application does asm ("pushf; popf") and the 2nd insn is probed. And otoh this is not enough.
See 6/7.
please let me know if you disagree.
Oleg.