uprobes: remove is_swbp_at_addr() from register/unregister
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | uprobes: Kill set_swbp()->is_swbp_at_addr()kernel/ | +0 | 5 replies | |
| 2/4 | uprobes: Introduce copy_opcode(), kill read_opcode()kernel/ | +19 | 1 reply | |
| 3/4 | uprobes: Kill set_orig_insn()->is_swbp_at_addr()kernel/ | +23 | 3 replies | |
| 4/4 | uprobes: Simplify is_swbp_at_addr(), remove stale commentskernel/ | +24 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Srikar Dronamraju |
|---|---|
| 1/4 | A-b |
| 2/4 | A-b |
| 3/4 | A-b |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] uprobes: remove is_swbp_at_addr() from register/unregister
Hello.
1. the usage of is_swbp_at_addr() is confusing. This series tries to answer the questions we got during the discussion about powerpc port which has multiple trap insns.
Ananth, please review too ;) at least the changelog in 1/4.
Note: the changelog doesn't mention is_swbp_insn(). If powerpc wants to change it, we need 2 helpers for verify_opcode() and for is_swbp_at_addr().
2. This is also preparation for the pre-filtering I am working on.
In particular, this series tries to make clear the fact that register/unregister should be "idempotent".
Oleg.
kernel/events/uprobes.c | 165 +++++++++++++++++------------------------------ 1 files changed, 59 insertions(+), 106 deletions(-)