Skip to content

add zip command support for uboot

Marek Vasut u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/6] add zip command support for uboot

Dear Lei Wen,

Quoted 10 lines · Marek Vasut
Quoted 9 lines

Dear Lukasz Majewski,

[...]

Quoted 5 lines
Quoted 1 line

Ok, that means we can make use of this command ?

I cannot promise, that I will provide the "zip" support straightaway in the DFU.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

On the one hand if DFU is the only user of this command we are adding in fact a "dead" code.
On the other hand we can use proper #define CONFIG_CMD_ZIP to not compile it until we "really" use this.

I'd rather see a user and code added, not the other way.

common/cmd_zip.c is another user. :)

I'm OK with this one.

Quoted 2 lines

And file systems could use the zip callback to directly create the zipped file.

Definitelly not ... zip callback for FS is wrong.

Quoted 3 lines

Since current ext4 and fat in uboot support write function, I think it could be
a potential feature to add.

cmd_zip + fs write call is OK. But why do we need to zip anything in uboot, what's the usecase?

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Are there any other potential "users" of this functionality (ZIP compression/decompression) in u-boot?

None that I know of. Is it really zip or is it gzip ?

It is porting from zlib, and is there any different for the compression side for
zip and gzip?

I ain't no expert, so I'm asking

Quoted 2 lines

This patch is pending for too long time, do we have a answer now whether it could be merged?

Ccing Tom

Quoted 2 lines

Thanks,
Lei

Best regards,
Marek Vasut