xfs: remove the xfssyncd mess
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest13 patches 10 repliesIn review
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | xfs: xfs_syncd_stop must diefs/ fs/ fs/ | +26 | 0 replies | |
| 2/13 | xfs: rationalise xfs_mount_wq usersfs/ fs/ fs/ | +23 | 0 replies | |
| 3/13 | xfs: dont run the sync work if the filesystem isfs/ fs/ | +18 | 0 replies | |
| 4/13 | xfs: sync work is now only periodic log workfs/ fs/ fs/ +4 more | +51 | 2 replies | |
| 5/13 | xfs: Bring some sanity to log unmountingfs/ fs/ | +26 | 0 replies | |
| 6/13 | xfs: xfs_sync_data is redundant.fs/ fs/ fs/ +4 more | +36 | 4 replies | |
| 7/13 | xfs: syncd workqueue is no morefs/ fs/ fs/ +2 more | +30 | 1 reply | |
| 8/13 | xfs: xfs_sync_fsdata is redundantfs/ fs/ | +14 | 0 replies | |
| 9/13 | xfs: move xfs_quiesce_attr() into xfs_super.cfs/ fs/ fs/ | +67 | 0 replies | |
| 10/13 | xfs: xfs_quiesce_attr() should quiesce the log likefs/ fs/ fs/ | +27 | 0 replies | |
| 11/13 | xfs: rename xfs_sync.[ch] to xfs_icache.[ch]fs/ fs/ fs/ +7 more | +763 | 0 replies | |
| 12/13 | xfs: move inode locking functions to xfs_inode.cfs/ fs/ | +250 | 0 replies | |
| 13/13 | xfs: remove xfs_iget.cfs/ fs/ fs/ +9 more | +430 | 0 replies |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mark Tinguely | Christoph Hellwig |
|---|---|---|
| Series | R-b | |
| 1/13 | R-b | R-b |
| 2/13 | R-b | R-b |
| 3/13 | R-b | R-b |
| 4/13 | R-b | |
| 5/13 | R-b | R-b |
| 6/13 | R-b | |
| 7/13 | R-b | |
| 8/13 | R-b | R-b |
| 9/13 | R-b | R-b |
| 10/13 | R-b | R-b |
| 11/13 | R-b | R-b |
| 12/13 | R-b | R-b |
| 13/13 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch v4 00/13] xfs: remove the xfssyncd mess
Hi Dave,
Here I am reposting your xfssyncd series. I want to make sure that we're all on the same page. In particular, are we all happy with patch 6, 'xfs: xfs_sync_data is redundant'?
Version 4:
- updated 'xfs: xfs_sync_data is redundant' with cleanups to the xfs_flush_inodes interface as per Christoph's request,
- updated 'xfs: xfs_sync_data is redundant', folding in changes from
http://oss.sgi.com/archives/xfs/2012-10/msg00036.html
- fixed a minor typo in xfs: 'syncd workqueue is no more', renaming the log worker from 'xfs-reclaim' to 'xfs-log'.
I was going to rush this in for the 3.7 merge window. However in the light of the issues with patch 6 and Linus's comment here:
http://lkml.org/lkml/2012/9/30/152 and Stephen's comment here:
https://lkml.org/lkml/2012/9/23/144, I think it wiser to behave. 3.7 is stable without this series, so I will merge it for 3.8.
Once we have an agreement that patch 6 is ready I will pull this in to the master branch first thing after the 3.7-rc1 merge from upstream.
Regards,
Ben
Version 3 of the patchset I described here:
http://oss.sgi.com/archives/xfs/2012-06/msg00064.html
This patchset reliably exposed the log->l_last_sync_lsn problem I just posted a fix for.
Version 3:
- per-mount log and reclaim workqueues instead of a generic mount workqueue.
- reordering of some of the patches as Christoph requested.
- fixed the writeback_inodes_sb_if_idle deadlock by moving it all the way back up the write stack to xfs_file_aio_buffered_write where we were just flushing the current file to avoid deadlocking on it anyway.
- reintroduced xfs_flush_inodes() as a wrapper for writeback_inodes_sb_if_idle().
- rebased on a current TOT.
Version 2:
- fix writeback_inodes_sb_if_idle call in xfs_create()
- refreshed patch 13 before sending.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs