Skip to content

Clean up improper dependencies on gettext without LOCALE

Arnout Vandecappelle (Essensium/Mind) buildroot 1 version New

Get series with b4
b4 am 20121014210734.17845.64519.stgit@localhost

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10diffutils: only needs gettext if locale is selectedpackage/diffutils/Config.in package/diffutils/diffutils.mk+2 -21 reply
2/10flex: only needs gettext if locale is selectedpackage/flex/Config.in package/flex/flex.mk+2 -21 reply
3/10ndisc6: only needs gettext if locale is selectedpackage/ndisc6/Config.in package/ndisc6/ndisc6.mk+2 -11 reply
4/10util-linux: only needs gettext if locale is selectedpackage/util-linux/Config.in package/util-linux/util-linux.mk+2 -11 reply
5/10lshw: fix build with no LOCALE supportpackage/lshw/Config.in package/lshw/lshw.mk+10 -40 replies
6/10avahi: remove double dependency on gettextpackage/avahi/avahi.mk+1 -41 reply
7/10pulseaudio: remove dependency on gettextpackage/multimedia/pulseaudio/Config.in package/multimedia/pulseaudio/pulseaudio.mk+0 -21 reply
8/10gdk-pixbuf: remove dependency on gettextpackage/gdk-pixbuf/Config.in package/gdk-pixbuf/gdk-pixbuf.mk+0 -20 replies
9/10glib-networking: remove redundant dependency on gettextpackage/glib-networking/Config.in+1 -11 reply
9/10glib-networking: remove redundant dependency on gettext+0 -00 replies
9/10glib-networking: remove redundant dependency on gettext+0 -00 replies
10/10libsoup: remove redundant dependency on gettextpackage/libsoup/Config.in+1 -11 reply
10/10libsoup: remove redundant dependency on gettext+0 -00 replies

Reviews trailers per patch

5 of 13 patches have a Reviewed-by or Acked-by.

PatchYann E. MORIN
1/10A-b
2/10A-b
3/10A-b
4/10A-b
5/10
6/10A-b
7/10
8/10
9/10
9/10
9/10
10/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 00/10] Clean up improper dependencies on gettext without LOCALE

This is a resend of a series that cleans up redundant dependencies on gettext, in packages that select gettext when LOCALE is not enabled.

The first 7 patches really remove the gettext dependency. The last three are in fact a NOP, because libglib2 selects gettext unconditionally. I have kept the NEEDS_GETTEXT_IF_LOCALE dependency for these packages, because they do have i18n code and do require libintl. But the dependency adds nothing, because libglib2 does the same already.

There are no changes compared to the first send, except for patch 7 which received a comment from Thomas Petazzoni.

Regards,
Arnout
---

Arnout Vandecappelle (Essensium/Mind) (10):
diffutils: only needs gettext if locale is selected
flex: only needs gettext if locale is selected
ndisc6: only needs gettext if locale is selected
util-linux: only needs gettext if locale is selected
lshw: fix build with no LOCALE support
avahi: remove double dependency on gettext
pulseaudio: remove dependency on gettext
gdk-pixbuf: remove dependency on gettext
glib-networking: remove redundant dependency on gettext
libsoup: remove redundant dependency on gettext

 package/avahi/avahi.mk                      |    5 +----
 package/diffutils/Config.in                 |    1 +
 package/diffutils/diffutils.mk              |    3 +--
 package/flex/Config.in                      |    1 +
 package/flex/flex.mk                        |    3 +--
 package/gdk-pixbuf/Config.in                |    1 -
 package/gdk-pixbuf/gdk-pixbuf.mk            |    1 -
 package/glib-networking/Config.in           |    2 +-
 package/libsoup/Config.in                   |    2 +-
 package/lshw/Config.in                      |    2 +-
 package/lshw/lshw.mk                        |   12 +++++++++---
 package/multimedia/pulseaudio/Config.in     |    1 -
 package/multimedia/pulseaudio/pulseaudio.mk |    1 -
 package/ndisc6/Config.in                    |    1 +
 package/ndisc6/ndisc6.mk                    |    2 +-
 package/util-linux/Config.in                |    1 +
 package/util-linux/util-linux.mk            |    2 +-
 17 files changed, 21 insertions(+), 20 deletions(-)