Skip to content

ARM: Kirkwood: Convert to pinctrl

Thomas Petazzoni linux-arm-kernel 1 version New

Get series with b4
b4 am 20121024233356.1bda95bf@skate

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: Kirkwood: Convert to pinctrl

Andrew,

Quoted 6 lines · Andrew Lunn

I guess it is too early to use gpio. I don't think the gpio driver has not been configured yet.

I need to think about this.

What happens if you comment out these two gpio_set_value calls?

The problem is (probably, I haven't tested) that in mach-kirkwood/board-dt.c, the of_platform_populate() function is called after all the board-specific init. So all the devices described in the DT, including GPIO banks, have not been registered yet. Most likely the of_platform_populate() should come before the board specific inits.

Also there should probably be a gpio_request() before those gpio_set_value().

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Read the cover letter in its thread