Skip to content

ARM: Kirkwood: Convert to pinctrl

Thomas Petazzoni linux-arm-kernel 1 version New

Get series with b4
b4 am 20121025094343.58015440@skate

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: Kirkwood: Convert to pinctrl

Dear Michael Walle,

Quoted 3 lines · Michael Walle

LSXL_GPIO_USB_POWER and LSXL_GPIO_HDD_POWER switches the power on the USB and SATA connector. So they are not needed to be set before the driver probes, at least in my case here.

Ok.

Quoted 4 lines

But i can imagine boards where you have to enable some kind of buffer/muxer/etc which are controlled by GPIO pins. And I don't think that should be part of the actual driver, because that would be highly board dependant.

You'd have to provide a more specific example so I can imagine how it will be solved. But for example, if you have a GPIO-controlled muxer for an I2C bus, then the I2C devices behind the muxer are described as sub-devices of the muxer, so the probing order is correct.

Of course, I'm not pretending I have ready-to-use solutions for all situations, but I think we can solve this problem on a case-by-case basis.

Regardless of those GPIOs, did you solve the hang that happened even when you removed the gpio_set_value() calls? Or is it still a problem currently?

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com