Skip to content

ARM: Kirkwood: Convert to pinctrl

Michael Walle linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: Kirkwood: Convert to pinctrl

Am Donnerstag 25 Oktober 2012, 09:43:43 schrieb Thomas Petazzoni:

Quoted 14 lines

Dear Michael Walle,

Quoted 3 lines · Michael Walle

LSXL_GPIO_USB_POWER and LSXL_GPIO_HDD_POWER switches the power on the USB and SATA connector. So they are not needed to be set before the driver probes, at least in my case here.

Ok.

Quoted 4 lines

But i can imagine boards where you have to enable some kind of buffer/muxer/etc which are controlled by GPIO pins. And I don't think that should be part of the actual driver, because that would be highly board dependant.

Quoted 4 lines

You'd have to provide a more specific example so I can imagine how it will be solved. But for example, if you have a GPIO-controlled muxer for an I2C bus, then the I2C devices behind the muxer are described as sub-devices of the muxer, so the probing order is correct.

Assume an ethernet phy which needs a valid reference clock before it can be probed for example. Of course, this is pure theoretical. But should we impose restrictions on when we can do the GPIO settings? Esp. since it worked before (i guess).

Quoted 7 lines

Of course, I'm not pretending I have ready-to-use solutions for all situations, but I think we can solve this problem on a case-by-case basis.

Regardless of those GPIOs, did you solve the hang that happened even when you removed the gpio_set_value() calls? Or is it still a problem currently?

Still a problem. Haven't really looket into i atm. Hopefully i find some time this weekend.

Signature · 1 line
michael