RFC Introduce .get_voltage callback into voltdm
Get series with b4
b4 am 20121026194021.3141.73709@nucleusVersions newest first
- v1 RFC Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm
Quoting Kevin Hilman (2012-10-26 11:17:51)
Quoted 11 lines
Hi Mike,
Quoted 6 lines · Mike Turquette
From: Mike Turquette <[email protected]>
This series creates a new callback for struct voltagedomain, .get_voltage. This fetches the voltage from hardware, if possible, and returns it to the caller. We use this call to populate
voltdm->nominal_voltat boot time.
Quoted 9 lines
I pointed out a couple nitpicky things on individual patches, but otherwise this direction and motiviation for this series looks OK by me.
Just some minor comments about the structure of the series. I tend to prefer combining the introduction of a new function with it's usage. It makes review and understanding much easier, IMO. If there are reasons to keep them separate, that's fine too. Just describe the reasons in the cover letter.
Will do. I've thought on this topic a bit more and this approach isn't quite robust enough. For instance it assumes that the kernel's voltage scaling approach (vp_forceupdate vs. vc_bypass) matches what the bootloader does. This is of course an unsafe assumption.
Also I've seen the Android guys struggle with this a bit and I'd like to review how they approached the problem before sending my next series. Couple with upcoming travel I'm not sure how quickly I'll get a V2 on the list.
Thanks for reviewing,
Mike
Quoted 3 lines
Thanks,
Kevin