Skip to content

uprobes: Kill arch_uprobe_enable/disable_step() hooks

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume()arch/powerpc/kernel/signal.c+1 -35 replies
2/4uprobes/powerpc: Do not use arch_uprobe_*_step() helpersarch/powerpc/kernel/uprobes.c kernel/events/uprobes.c+6 -22 replies
3/4uprobes/x86: Cleanup the single-stepping codearch/x86/kernel/uprobes.c+19 -351 reply
4/4uprobes: Kill arch_uprobe_enable/disable_step() hooksinclude/linux/uprobes.h kernel/events/uprobes.c+0 -121 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAnanth N MavinakayanahalliSrikar Dronamraju
1/4A-b A-b
2/4A-b A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks

Hello.

arch_uprobe_enable/disable_step() were only needed to not break the pending powerpc port. They buy nothing and they are simply wrong. Uprobes should not use ptrace helpers for the stepping.

Now that powepc port was merged we should kill them asap, before arm port.

1/4 is minor/offtopic cleanup. powerpc changes were not tested at all and thus need the review from Ananth.

Oleg.