Skip to content

Factorize ARM startup code as mush as possible.

Sughosh Ganu u-boot 4 versions – New

Get series with b4
b4 am 20121209203133.GA3607@Hardy

Versions newest first · linked by author and title

  1. v2 Latest posting 4/40 of 2 patches 0 repliesNew
  2. v2 posting 3/40 of 2 patches 0 repliesSuperseded
  3. v2 posting 2/40 of 2 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v2 posting 1/40 of 2 patches0 repliesSuperseded

Patches in v2 posting 4/4 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/2] Factorize ARM startup code as mush as possible.

hi Albert,
On Tue Nov 13, 2012 at 08:55:23PM +0100, Albert ARIBAUD wrote:

<snip>

Quoted 36 lines
Quoted 27 lines
Quoted 27 lines
Quoted 9 lines

I tried the 1st patch of the series, and with that u-boot does not come up on the board. It is also printing out some random values for the dram and nand sizes.

The patch was applied on top of commit 1cc619be8b7. Also, with the mentioned commit, u-boot boots up fine on the board. Also to be noted is that the spl image compiled with these changes is booting up fine, loading the main u-boot image, and jumping to it -- the issue is with booting the main u-boot image.

Thanks Sughosh. Can you build an U-Boot with the following defined in the hawkboard.h config file?

#define DEBUG
#if defined(CONFIG_SPL_BUILD) && ! defined (__ASSEMBLY__) static inline int printf(const char *fmt, ...)

{
        return 0;
}

#endif

Note: only the #define DEBUG matter to me, but with it alone, SPL build fails due to some code now requiring printf(). This is why I add a dummy printf definition for C code during SPL build -- ASM code does not need printf() and actually chokes on the definition, hence the condition on __ASSEMBLY__.

Quoted 9 lines
Quoted 3 lines

This debug U-Boot should print a lot more info. Can you please try it and copy/paste its output here? Thanks in advance.

Unfortunately i am currently on vacation, with no access to the board, and
would be able to try out your suggested changes only after i am back, by
the end of next week. In the meantime, i am also trying to get myself a jtag debugger -- it is quite frustrating to provide half baked information.

Quoted 5 lines

Thanks for the feedback. Meanwhile, I have found two ugly bugs which would certainly affect execution past board_init_f(), so maybe your hawkboard was bitten by theses; next time please try v3, which fixes these bugs, or the latest patch version if v3 is obsolete by the time you come back.

I tested the v4 of your patches on hawkboard, and now the board boots up fine. Sorry, i took a little longer than i had expected to be back, so this got a bit delayed.

-sughosh