Skip to content

discontiguous buffer patches

Mark Tinguely linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 7 repliesIn review
  2. v23 patches 9 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xfs: use b_maps[] for discontiguous buffersfs/xfs/xfs_buf.c fs/xfs/xfs_buf.h+9 -91 reply
2/5xfs: rename bli_format to avoid confusion with bli_formatsfs/xfs/xfs_buf_item.c fs/xfs/xfs_buf_item.h fs/xfs/xfs_trans_buf.c+24 -241 reply
3/5xfs: fix segment in xfs_buf_item_format_segmentfs/xfs/xfs_buf_item.c+15 -52 replies
4/5xfs: fix the multi-segment log buffer formatfs/xfs/xfs_buf_item.c fs/xfs/xfs_trans_buf.c+15 -52 replies
5/5xfs remove the XFS_TRANS_DEBUG routinesfs/xfs/xfs_buf_item.c fs/xfs/xfs_buf_item.h fs/xfs/xfs_inode.c +4 more+0 -2011 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchDave ChinnerChristoph Hellwig
1/5R-b R-b
2/5R-b
3/5
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] discontiguous buffer patches

Eric Sundeen's "userspace vs. fragmented multiblock dir2", xfstest 291 commit 2a4ed, causes a xfs_buf lock hang:

[<ffffffff81065d87>] down+0x47/0x50
[<ffffffffa03a25c6>] xfs_buf_lock+0x66/0xe0 [xfs]
[<ffffffffa03a33c9>] _xfs_buf_find+0x1f9/0x320 [xfs]
[<ffffffffa03a393f>] xfs_buf_get_map+0x2f/0x170 [xfs]
[<ffffffffa03a3f7a>] xfs_buf_read_map+0x2a/0x100 [xfs]
[<ffffffffa0411630>] xfs_trans_read_buf_map+0x3b0/0x590 [xfs]
[<ffffffffa03e1c5e>] xfs_da_read_buf+0xbe/0x230 [xfs]
[<ffffffffa03e78dc>] xfs_dir2_block_addname+0x7c/0x980 [xfs]
[<ffffffffa03f1468>] xfs_dir2_sf_addname+0x3e8/0x450 [xfs]
[<ffffffffa03e634c>] xfs_dir_createname+0x17c/0x1e0 [xfs]
[<ffffffffa03b9fe2>] xfs_create+0x4c2/0x5f0 [xfs]
[<ffffffffa03b0c8a>] xfs_vn_mknod+0x8a/0x1a0 [xfs]
[<ffffffffa03b0dce>] xfs_vn_create+0xe/0x10 [xfs]
[<ffffffff8115695c>] vfs_create+0xac/0xd0
[<ffffffff811587de>] do_last+0x8be/0x960
[<ffffffff8115940c>] path_openat+0xdc/0x410
[<ffffffff81159853>] do_filp_open+0x43/0xa0
[<ffffffff8114a502>] do_sys_open+0x152/0x1e0
[<ffffffff8114a5cc>] sys_open+0x1c/0x20
[<ffffffff81423df9>] system_call_fastpath+0x16/0x1b

[<ffffffffffffffff>] 0xffffffffffffffff

Changes to the series from version 2:

Patch 2: The renaming of b_map to __b_map is in its own patch.

Patch 3: The buffer log format assert is in its own patch and simplies the
initialization per Dave's suggestion.

Patch 5: The XFS_TRANS_DEBUG is completely removed from xfs.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs