Skip to content

ARM: OMAP: ads7846: fix pendown debounce setting

Tony Lindgren linux-arm-kernel linux-input linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 2 patches 0 repliesNew

1 of 2 patches is in this archive. The cover letter announces 2.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/2ARM: OMAP: ads7846: fix pendown debounce setting+0 -00 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchTony Lindgren
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
Quoted 27 lines · Dmitry Torokhov
Quoted 26 lines · Igor Grinberg

Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the pendown GPIO debounce time setting by the below sequence:

gpio_request_one()
gpio_set_debounce()
gpio_free()

It also revealed a bug in the OMAP GPIO handling code which prevented the GPIO debounce clock to be disabled and CORE transition to low power states.

Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on free/reset) fixes the OMAP GPIO handling code by making sure that the GPIO debounce clock gets disabled if no GPIO is requested from current bank.

While fixing the OMAP GPIO handling code (in the right way), the above commit makes the gpio_request->set_debounce->free sequence invalid as after freeing the GPIO, the debounce settings are lost.

This patch set:
1) Adds the pendown GPIO debounce time setting to the platform data structure of the ads7846 driver.
2) Fixes the OMAP platform code to pass the debounce time value to the driver instead of handling it by itself.

Quoted 7 lines
Quoted 4 lines

Igor Grinberg (2):
ads7846: enable pendown GPIO debounce time setting
ARM: OMAP: ads7846: fix pendown debounce setting

Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind if I pick OMAP change as well?

No please go ahead, I just acked the related patch.

Regards,

Tony