uprobes: register/unregister preparations for filtering
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe()kernel/ | +2 | 1 reply | |
| 2/7 | uprobes: Kill the "uprobe != NULL" check in uprobe_unregister()kernel/ | +1 | 1 reply | |
| 3/7 | uprobes: Kill the pointless inode/uc checks in register/unregisterkernel/ | +1 | 6 replies | |
| 4/7 | uprobes: Kill uprobe_consumer->filter()include/ kernel/ kernel/ | +2 | 1 reply | |
| 5/7 | uprobes: Introduce filter_chain()kernel/ | +19 | 2 replies | |
| 6/7 | uprobes: _unregister() should always do register_for_each_vma(false)kernel/ | +14 | 0 replies | |
| 7/7 | uprobes: _register() should always do register_for_each_vma(true)kernel/ | +13 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Srikar Dronamraju |
|---|---|
| 1/7 | A-b |
| 2/7 | A-b |
| 3/7 | A-b |
| 4/7 | A-b |
| 5/7 | A-b |
| 6/7 | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] uprobes: register/unregister preparations for filtering
Hello.
Srikar, it is not clear if you was convinced or not during the last discussion. We will discuss this again probably. So far I am sending the initial changes which (I think) make sense in any case. Please review.
The next step is locking. Alas, we can not use consumer_rwsem to protect the list in filter_chain(). Whatever we do, at least uprobe_mmap() needs to do this under mm->mmap_sem. And we do want to allow uc->handler() to play with current->mm.
Then we will actually immplement filter_chain(), this should be trivial unless you insist we need for_each_mm_user() (cough, I hope you do not ;).
Then we will try to solve the problem with fork.
Oleg.