Skip to content

tracing: Review of changes

Steven Rostedt lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13tracing: Fix sparse warning with is_signed_type() macroinclude/linux/ftrace_event.h+1 -10 replies
2/13ring-buffer: Remove unnecessary recusive call in rb_advance_iter()kernel/trace/ring_buffer.c+1 -10 replies
3/13tracing: Use this_cpu_ptr per-cpu helperkernel/trace/blktrace.c kernel/trace/trace.c+2 -50 replies
4/13tracing: Verify target file before registering a uprobe eventkernel/trace/trace_uprobe.c+5 -10 replies
5/13tracing/syscalls: Make local functions statickernel/trace/trace_syscalls.c+9 -90 replies
6/13tracing: Add checks if tr->buffer is NULL in tracing_reset{_online_cpus}kernel/trace/trace.c+6 -00 replies
7/13tracing: Remove unneeded check of max_tr->buffer before tracing_resetkernel/trace/trace.c+1 -20 replies
8/13tracing/lockdep: Disable lockdep first in entering NMIinclude/linux/hardirq.h+2 -20 replies
9/13tracing/fgraph: Add max_graph_depth to limit function_graph depthkernel/trace/trace_functions_graph.c+58 -20 replies
10/13ftrace: Move ARCH_SUPPORTS_FTRACE_SAVE_REGS in Kconfigarch/x86/Kconfig arch/x86/include/asm/ftrace.h include/linux/ftrace.h +3 more+16 -80 replies
11/13kprobes/x86: Move ftrace-based kprobe code into kprobes-ftrace.carch/Kconfig arch/x86/Kconfig arch/x86/kernel/Makefile +5 more+125 -830 replies
12/13kprobes/x86: Move kprobes stuff under arch/x86/kernel/kprobes/arch/x86/kernel/Makefile arch/x86/kernel/kprobes-common.h arch/x86/kernel/kprobes-ftrace.c +7 more+1790 -17850 replies
13/13tracing: Remove the extra 4 bytes of padding in eventsinclude/linux/ftrace_event.h kernel/trace/trace.c kernel/trace/trace_events.c+0 -31 reply

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchChristoph LameterSrikar DronamrajuArjan van de Ven
1/13
2/13
3/13R-b
4/13A-b
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/13 -next] [For linux-next] tracing: Review of changes

I'm posting these as a generic review of the changes I'll be pushing into linux-next and will be pushing this for 3.9.

These patches have passed a series of tests I've run on few machines with several different configs and such.

You can find the patches here. I'll add these to linux-next tomorrow.

-- Steve

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
tip/perf/core

Head SHA1: a701a1b03bf36d4e31c9fd036a96bde5a11cd5ce

Fengguang Wu (1):
tracing/syscalls: Make local functions static

Hiraku Toyooka (1):

      tracing: Add checks if tr->buffer is NULL in tracing_reset{_online_cpus}

Jovi Zhang (1):
tracing: Verify target file before registering a uprobe event

Masami Hiramatsu (3):
ftrace: Move ARCH_SUPPORTS_FTRACE_SAVE_REGS in Kconfig kprobes/x86: Move ftrace-based kprobe code into kprobes-ftrace.c kprobes/x86: Move kprobes stuff under arch/x86/kernel/kprobes/

Shan Wei (1):
tracing: Use this_cpu_ptr per-cpu helper

Steven Rostedt (6):
tracing: Fix sparse warning with is_signed_type() macro
ring-buffer: Remove unnecessary recusive call in rb_advance_iter()
tracing: Remove unneeded check of max_tr->buffer before tracing_reset tracing/lockdep: Disable lockdep first in entering NMI tracing/fgraph: Add max_graph_depth to limit function_graph depth
tracing: Remove the extra 4 bytes of padding in events

----

 arch/Kconfig                         |   12 +
 arch/x86/Kconfig                     |    2 +
 arch/x86/include/asm/ftrace.h        |    1 -
 arch/x86/kernel/Makefile             |    3 +-
 arch/x86/kernel/kprobes-common.h     |  102 ---
 arch/x86/kernel/kprobes-opt.c        |  512 ---------------
 arch/x86/kernel/kprobes.c            | 1130 ----------------------------------
 arch/x86/kernel/kprobes/Makefile     |    7 +
 arch/x86/kernel/kprobes/common.h     |  113 ++++
 arch/x86/kernel/kprobes/core.c       | 1064 ++++++++++++++++++++++++++++++++
 arch/x86/kernel/kprobes/ftrace.c     |   93 +++
 arch/x86/kernel/kprobes/opt.c        |  512 +++++++++++++++
 include/linux/ftrace.h               |    6 +-
 include/linux/ftrace_event.h         |    3 +-
 include/linux/hardirq.h              |    4 +-
 include/linux/kprobes.h              |   12 +-
 kernel/kprobes.c                     |    8 +-
 kernel/trace/Kconfig                 |    8 +
 kernel/trace/blktrace.c              |    2 +-
 kernel/trace/ftrace.c                |    6 +-
 kernel/trace/ring_buffer.c           |    2 +-
 kernel/trace/trace.c                 |   15 +-
 kernel/trace/trace_events.c          |    1 -
 kernel/trace/trace_functions_graph.c |   60 +-
 kernel/trace/trace_selftest.c        |    2 +-
 kernel/trace/trace_syscalls.c        |   18 +-
 kernel/trace/trace_uprobe.c          |    6 +-
 27 files changed, 1909 insertions(+), 1795 deletions(-)