Skip to content

OMAP SHAM & AES Crypto Updates

Mark A. Greer linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 15 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 15 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] OMAP SHAM & AES Crypto Updates
Quoted 43 lines · Paul Walmsley

Hi Mark

Quoted 13 lines · Mark A. Greer
Quoted 12 lines · Mark A. Greer
Quoted 10 lines · Paul Walmsley
Quoted 1 line · Mark A. Greer

On Sun, Dec 23, 2012 at 08:40:43AM +0000, Paul Walmsley wrote:

What do you think about adding an am35xx_es11plus_hwmod_ocp_ifs[] array to omap_hwmod_3xxx_data.c for these secure hwmods? That carries the implicit and possibly wrong assumption that it's likely to be ES1.0 devices that are missing the SHAM/AES, but it seems unlikely that TI would have multiple silicon revs running around claiming to be ES1.1? Or maybe I'm just being na?ve.

Quoted 6 lines
Quoted 2 lines

Something like that makes sense to me. I'll re-read my email, etc. and see if I can find something to help us figure it out.

I couldn't find any information that helped with this so AFAIK there is no good way to tell if a particular am35xx has the crypto hardware available or not.

I was thinking that we might assume that they are present on AM35xx ES1.1+. If the TI folks are saying that they aren't available on only a few early devices, I'd guess that means ES1.0. I personally have never seen an ES1.0 AM35xx device...

Discriminating between ES1.0 and ES1.1+ should be pretty easy in the hwmod init...

Quoted 3 lines

At this point, I vote for moving 'omap3xxx_l4_core__sham' and
'omap3xxx_l4_core__aes' from omap3xxx_gp_hwmod_ocp_ifs[] and putting them in omap34xx_hwmod_ocp_ifs[] and omap36xx_hwmod_ocp_ifs[].

I'm pretty sure that's going to break on HS OMAPs, like the HS OMAP3430 in the N900. I don't think those IP blocks are directly accessible from Linux on most HS setups, although this might vary by device. I'd feel more comfortable if you created an omap34xx_gp_hwmod_ocp_ifs[] list and an omap36xx_gp_hwmod_ocp_ifs[] list. We should probably get rid of omap3xxx_gp_hwmod_ocp_ifs[] altogether.

Quoted 8 lines
Quoted 2 lines

That should be safe in general and if someone with an am35xx wants to use those modules, they can edit am35xx_hwmod_ocp_ifs[] locally.

If you want to just leave them commented in am35xx_hwmod_ocp_ifs[], rather than enabling them for ES1.1+ AM35xx, that's fine with me too, since we don't know that they are ES-level-based. Maybe put a comment there that says that these are likely to be present, but no one seems to know for certain? Seems ludicrous, but I guess that's what we're reduced to!

Thanks Paul. I will have some patches early next week.

Mark
--